Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1215)

Side by Side Diff: Source/core/html/HTMLTableCellElement.h

Issue 1198393002: HTMLTableCellElement type changed from signed to unsinged (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Reverted cellIndex changes and updated layout test o correspond with the changes. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2010 Apple Inc. All rights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2010 Apple Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 20 matching lines...) Expand all
31 31
32 namespace blink { 32 namespace blink {
33 33
34 class CORE_EXPORT HTMLTableCellElement final : public HTMLTablePartElement { 34 class CORE_EXPORT HTMLTableCellElement final : public HTMLTablePartElement {
35 DEFINE_WRAPPERTYPEINFO(); 35 DEFINE_WRAPPERTYPEINFO();
36 public: 36 public:
37 DECLARE_ELEMENT_FACTORY_WITH_TAGNAME(HTMLTableCellElement); 37 DECLARE_ELEMENT_FACTORY_WITH_TAGNAME(HTMLTableCellElement);
38 38
39 int cellIndex() const; 39 int cellIndex() const;
40 40
41 int colSpan() const; 41 unsigned colSpan() const;
42 int rowSpan() const; 42 unsigned rowSpan() const;
43 43
44 void setCellIndex(int); 44 void setCellIndex(int);
45 45
46 const AtomicString& abbr() const; 46 const AtomicString& abbr() const;
47 const AtomicString& axis() const; 47 const AtomicString& axis() const;
48 void setColSpan(int); 48 void setColSpan(unsigned);
49 const AtomicString& headers() const; 49 const AtomicString& headers() const;
50 void setRowSpan(int); 50 void setRowSpan(unsigned);
51 const AtomicString& scope() const; 51 const AtomicString& scope() const;
52 52
53 HTMLTableCellElement* cellAbove() const; 53 HTMLTableCellElement* cellAbove() const;
54 54
55 private: 55 private:
56 HTMLTableCellElement(const QualifiedName&, Document&); 56 HTMLTableCellElement(const QualifiedName&, Document&);
57 57
58 virtual void parseAttribute(const QualifiedName&, const AtomicString&) overr ide; 58 virtual void parseAttribute(const QualifiedName&, const AtomicString&) overr ide;
59 virtual bool isPresentationAttribute(const QualifiedName&) const override; 59 virtual bool isPresentationAttribute(const QualifiedName&) const override;
60 virtual void collectStyleForPresentationAttribute(const QualifiedName&, cons t AtomicString&, MutableStylePropertySet*) override; 60 virtual void collectStyleForPresentationAttribute(const QualifiedName&, cons t AtomicString&, MutableStylePropertySet*) override;
61 virtual const StylePropertySet* additionalPresentationAttributeStyle() overr ide; 61 virtual const StylePropertySet* additionalPresentationAttributeStyle() overr ide;
62 62
63 virtual bool isURLAttribute(const Attribute&) const override; 63 virtual bool isURLAttribute(const Attribute&) const override;
64 virtual bool hasLegalLinkAttribute(const QualifiedName&) const override; 64 virtual bool hasLegalLinkAttribute(const QualifiedName&) const override;
65 virtual const QualifiedName& subResourceAttributeName() const override; 65 virtual const QualifiedName& subResourceAttributeName() const override;
66 }; 66 };
67 67
68 inline bool isHTMLTableCellElement(const HTMLElement& element) 68 inline bool isHTMLTableCellElement(const HTMLElement& element)
69 { 69 {
70 return element.hasTagName(HTMLNames::tdTag) || element.hasTagName(HTMLNames: :thTag); 70 return element.hasTagName(HTMLNames::tdTag) || element.hasTagName(HTMLNames: :thTag);
71 } 71 }
72 72
73 DEFINE_HTMLELEMENT_TYPE_CASTS_WITH_FUNCTION(HTMLTableCellElement); 73 DEFINE_HTMLELEMENT_TYPE_CASTS_WITH_FUNCTION(HTMLTableCellElement);
74 74
75 } // namespace blink 75 } // namespace blink
76 76
77 #endif // HTMLTableCellElement_h 77 #endif // HTMLTableCellElement_h
OLDNEW
« no previous file with comments | « LayoutTests/fast/dom/HTMLTableCellElement/rowspan-attribute-expected.txt ('k') | Source/core/html/HTMLTableCellElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698