[Import] [OSX] Don't create an empty folder when importing from Safari with an empty Bookmarks Menu.

[Import] [OSX] Don't create an empty folder when importing from Safari with an empty Bookmarks Menu.

Also moves test files around:
  (1) The data previously in chrome/test/data/safari_import/ was moved to chrome/test/data/import/safari/default/.
  (2) A new test data directory was created at chrome/test/data/import/safari/empty_bookmarks_menu/.

BUG=248431
TEST=unit_tests
R=jeremy@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243494

[jeremy, 2013-12-22 13:14:22]

https://codereview.chromium.org/119833002/diff/1/chrome/test/data/import/safa...
File chrome/test/data/import/safari/default/README (right):

https://codereview.chromium.org/119833002/diff/1/chrome/test/data/import/safa...
chrome/test/data/import/safari/default/README:2: this directory were written by
Safari v4.0.2 on OS X 10.5.7.  In the
driveby: We no longer support OS X 10.5, and this is a really old version of
Safair.  Suggest filing a bug for importing a new Safari profile.

https://codereview.chromium.org/119833002/diff/1/chrome/test/data/import/safa...
File chrome/test/data/import/safari/empty_bookmarks_menu/README (right):

https://codereview.chromium.org/119833002/diff/1/chrome/test/data/import/safa...
chrome/test/data/import/safari/empty_bookmarks_menu/README:2: this directory
were written by Safari v4.0.2 on OS X 10.5.7.  In the
How did you generate this profile directory?

https://codereview.chromium.org/119833002/diff/1/chrome/utility/importer/safa...
File chrome/utility/importer/safari_importer_unittest.mm (right):

https://codereview.chromium.org/119833002/diff/1/chrome/utility/importer/safa...
chrome/utility/importer/safari_importer_unittest.mm:157: // Expected results
nit: results.

[Ilya Sherman, 2014-01-08 05:26:36]

https://codereview.chromium.org/119833002/diff/1/chrome/test/data/import/safa...
File chrome/test/data/import/safari/default/README (right):

https://codereview.chromium.org/119833002/diff/1/chrome/test/data/import/safa...
chrome/test/data/import/safari/default/README:2: this directory were written by
Safari v4.0.2 on OS X 10.5.7.  In the
On 2013/12/22 13:14:22, jeremy wrote:
> driveby: We no longer support OS X 10.5, and this is a really old version of
> Safair.  Suggest filing a bug for importing a new Safari profile.

Filed https://code.google.com/p/chromium/issues/detail?id=332289

https://codereview.chromium.org/119833002/diff/1/chrome/test/data/import/safa...
File chrome/test/data/import/safari/empty_bookmarks_menu/README (right):

https://codereview.chromium.org/119833002/diff/1/chrome/test/data/import/safa...
chrome/test/data/import/safari/empty_bookmarks_menu/README:2: this directory
were written by Safari v4.0.2 on OS X 10.5.7.  In the
On 2013/12/22 13:14:22, jeremy wrote:
> How did you generate this profile directory?

Done.  Also removed most of the files from this directory, as they were not
needed for the test.

https://codereview.chromium.org/119833002/diff/1/chrome/utility/importer/safa...
File chrome/utility/importer/safari_importer_unittest.mm (right):

https://codereview.chromium.org/119833002/diff/1/chrome/utility/importer/safa...
chrome/utility/importer/safari_importer_unittest.mm:157: // Expected results
On 2013/12/22 13:14:22, jeremy wrote:
> nit: results.

Done.

[jeremy, 2014-01-08 05:30:39]

LGTM - please add detailed description of changes to safari test data directory
to the CL description.

[Ilya Sherman, 2014-01-08 05:34:11]

On 2014/01/08 05:30:39, jeremy wrote:
> LGTM - please add detailed description of changes to safari test data
directory
> to the CL description.

Done.  Thanks for the quick review! :)

[commit-bot: I haz the power, 2014-01-08 05:34:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/isherman@chromium.org/119833002/70001

[commit-bot: I haz the power, 2014-01-08 05:35:10]

Failed to request the patch to try. Please note that binary files are still
unsupported at the moment, this is being worked on.

Thanks for your patience.

HTTP Error 500: Internal Server Error

[Ilya Sherman, 2014-01-08 06:16:29]

Committed patchset #2 manually as r243494 (presubmit successful).