[Import] [OSX] Don't create an empty folder when importing from Safari with an empty Bookmarks Menu.

chrome/utility/importer/safari_importer_unittest.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/utility/importer/safari_importer.h"
 
 #include "base/basictypes.h"
 #include "base/file_util.h"
 #include "base/files/file_path.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/path_service.h"
 #include "base/strings/string16.h"
 #include "base/strings/string_util.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/importer/imported_bookmark_entry.h"
 #include "chrome/common/importer/imported_favicon_usage.h"
 #include "chrome/common/importer/importer_bridge.h"
 #include "chrome/common/importer/safari_importer_utils.h"
 #include "chrome/utility/importer/safari_importer.h"
 #include "sql/connection.h"
 #include "testing/platform_test.h"
 
 // In order to test the Safari import functionality effectively, we store a
 // simulated Library directory containing dummy data files in the same
 // structure as ~/Library in the Chrome test data directory.
 // This function returns the path to that directory.
-base::FilePath GetTestSafariLibraryPath() {
+base::FilePath GetTestSafariLibraryPath(const std::string& suffix) {
   base::FilePath test_dir;
   PathService::Get(chrome::DIR_TEST_DATA, &test_dir);
 
   // Our simulated ~/Library directory
-  test_dir = test_dir.AppendASCII("safari_import");
-  return test_dir;
+  return
+      test_dir.AppendASCII("import").AppendASCII("safari").AppendASCII(suffix);
 }
 
 class SafariImporterTest : public PlatformTest {
  public:
   SafariImporter* GetSafariImporter() {
-    base::FilePath test_library_dir = GetTestSafariLibraryPath();
-    CHECK(base::PathExists(test_library_dir))  <<
-        "Missing test data directory";
+    return GetSafariImporterWithPathSuffix("default");
+  }
 
+  SafariImporter* GetSafariImporterWithPathSuffix(const std::string& suffix) {
+    base::FilePath test_library_dir = GetTestSafariLibraryPath(suffix);
+    CHECK(base::PathExists(test_library_dir));
     return new SafariImporter(test_library_dir);
   }
 };
 
 TEST_F(SafariImporterTest, HistoryImport) {
   scoped_refptr<SafariImporter> importer(GetSafariImporter());
 
   std::vector<ImporterURLRow> history_items;
   importer->ParseHistoryItems(&history_items);
 
@@ skipping 89 matching lines @@
     Tokenize(kImportedBookmarksData[i].path, ASCIIToUTF16("/"), &path);
     ASSERT_EQ(path.size(), entry.path.size());
     for (size_t j = 0; j < path.size(); ++j) {
       EXPECT_EQ(path[j], entry.path[j]);
     }
 
     EXPECT_EQ(kImportedBookmarksData[i].title, entry.title);
   }
 }
 
+TEST_F(SafariImporterTest, BookmarkImportWithEmptyBookmarksMenu) {
+  // Expected results

[jeremy, 2013/12/22 13:14:22]

nit: results.

[Ilya Sherman, 2014/01/08 05:26:37]

Done.

+  const struct {
+    bool in_toolbar;
+    GURL url;
+    // We store the path with levels of nesting delimited by forward slashes.
+    string16 path;
+    string16 title;
+  } kImportedBookmarksData[] = {
+    {
+      true,
+      GURL("http://www.apple.com/"),
+      ASCIIToUTF16("Toolbar/"),
+      ASCIIToUTF16("Apple")
+    },
+    {
+      true,
+      GURL("http://www.yahoo.com/"),
+      ASCIIToUTF16("Toolbar/"),
+      ASCIIToUTF16("Yahoo!")
+    },
+    {
+      true,
+      GURL("http://www.cnn.com/"),
+      ASCIIToUTF16("Toolbar/News"),
+      ASCIIToUTF16("CNN")
+    },
+    {
+      true,
+      GURL("http://www.nytimes.com/"),
+      ASCIIToUTF16("Toolbar/News"),
+      ASCIIToUTF16("The New York Times")
+    },
+    {
+      false,
+      GURL("http://www.webkit.org/blog/"),
+      string16(),
+      ASCIIToUTF16("Surfin' Safari - The WebKit Blog")
+    },
+  };
+
+  scoped_refptr<SafariImporter> importer(
+      GetSafariImporterWithPathSuffix("empty_bookmarks_menu"));
+  std::vector<ImportedBookmarkEntry> bookmarks;
+  importer->ParseBookmarks(ASCIIToUTF16("Toolbar"), &bookmarks);
+  size_t num_bookmarks = bookmarks.size();
+  ASSERT_EQ(ARRAYSIZE_UNSAFE(kImportedBookmarksData), num_bookmarks);
+
+  for (size_t i = 0; i < num_bookmarks; ++i) {
+    ImportedBookmarkEntry& entry = bookmarks[i];
+    EXPECT_EQ(kImportedBookmarksData[i].in_toolbar, entry.in_toolbar);
+    EXPECT_EQ(kImportedBookmarksData[i].url, entry.url);
+
+    std::vector<string16> path;
+    Tokenize(kImportedBookmarksData[i].path, ASCIIToUTF16("/"), &path);
+    ASSERT_EQ(path.size(), entry.path.size());
+    for (size_t j = 0; j < path.size(); ++j) {
+      EXPECT_EQ(path[j], entry.path[j]);
+    }
+
+    EXPECT_EQ(kImportedBookmarksData[i].title, entry.title);
+  }
+}
+
 TEST_F(SafariImporterTest, FaviconImport) {
   scoped_refptr<SafariImporter> importer(GetSafariImporter());
   sql::Connection db;
   ASSERT_TRUE(importer->OpenDatabase(&db));
 
   SafariImporter::FaviconMap favicon_map;
   importer->ImportFaviconURLs(&db, &favicon_map);
 
   std::vector<ImportedFaviconUsage> favicons;
   importer->LoadFaviconData(&db, favicon_map, &favicons);
@@ skipping 17 matching lines @@
   EXPECT_TRUE(fav1.urls.find(GURL("http://www.opensearch.org/Home"))
       != fav1.urls.end());
 
   EXPECT_TRUE(fav1.urls.find(
       GURL("http://www.opensearch.org/Special:Search?search=lalala&go=Search"))
           != fav1.urls.end());
 }
 
 TEST_F(SafariImporterTest, CanImport) {
   uint16 items = importer::NONE;
-  EXPECT_TRUE(SafariImporterCanImport(GetTestSafariLibraryPath(), &items));
+  EXPECT_TRUE(SafariImporterCanImport(
+      GetTestSafariLibraryPath("default"), &items));
   EXPECT_EQ(items, importer::HISTORY | importer::FAVORITES);
   EXPECT_EQ(items & importer::COOKIES, importer::NONE);
   EXPECT_EQ(items & importer::PASSWORDS, importer::NONE);
   EXPECT_EQ(items & importer::SEARCH_ENGINES, importer::NONE);
   EXPECT_EQ(items & importer::HOME_PAGE, importer::NONE);
 
   // Check that we don't import anything from a bogus library directory.
   base::ScopedTempDir fake_library_dir;
   ASSERT_TRUE(fake_library_dir.CreateUniqueTempDir());
   EXPECT_FALSE(SafariImporterCanImport(fake_library_dir.path(), &items));
 }