pkg/compiler/lib/src/ssa/nodes.dart - Issue 1198293002: dart2js: Use an abstract Name class for names in the generated JavaScript ast.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/ssa/nodes.dart

Issue 1198293002: dart2js: Use an abstract Name class for names in the generated JavaScript ast. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Fix new emitter. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart ('K') | « pkg/compiler/lib/src/ssa/codegen.dart ('k') | pkg/compiler/lib/src/types/constants.dart » ('j') | pkg/js_ast/lib/src/nodes.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/ssa/nodes.dart

diff --git a/pkg/compiler/lib/src/ssa/nodes.dart b/pkg/compiler/lib/src/ssa/nodes.dart

index d047c7cede39b237fcc44316cae91b8fdb46b21c..01a76ee7b3be367e19ee928843be7e9d2b4e0249 100644

--- a/pkg/compiler/lib/src/ssa/nodes.dart

+++ b/pkg/compiler/lib/src/ssa/nodes.dart

@@ -211,6 +211,14 @@ class HGraph {

compiler);

}

+ HConstant addConstantStringFromName(js.Name name,

+ Compiler compiler) {

floitsch 2015/06/22 17:43:45 indentation.

herhut 2015/06/23 13:26:32 Done.

+ return addConstant(

+ new SyntheticConstantValue(SyntheticConstantKind.NAME,

+ js.quoteName(name)),

+ compiler);

+ }

HConstant addConstantBool(bool value, Compiler compiler) {

return addConstant(

compiler.backend.constantSystem.createBool(value), compiler);