dart2js: Use an abstract Name class for names in the generated JavaScript ast.

pkg/compiler/lib/src/ssa/nodes.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of ssa;
 
 abstract class HVisitor<R> {
   R visitAdd(HAdd node);
   R visitAwait(HAwait node);
   R visitBitAnd(HBitAnd node);
@@ skipping 193 matching lines @@
         compiler.backend.constantSystem.createDouble(d), compiler);
   }
 
   HConstant addConstantString(ast.DartString str,
                               Compiler compiler) {
     return addConstant(
         compiler.backend.constantSystem.createString(str),
         compiler);
   }
 
+  HConstant addConstantStringFromName(js.Name name,
+                            Compiler compiler) {

[floitsch, 2015/06/22 17:43:45]

indentation.

[herhut, 2015/06/23 13:26:32]

Done.

+    return addConstant(
+        new SyntheticConstantValue(SyntheticConstantKind.NAME,
+                                   js.quoteName(name)),
+        compiler);
+  }
+
   HConstant addConstantBool(bool value, Compiler compiler) {
     return addConstant(
         compiler.backend.constantSystem.createBool(value), compiler);
   }
 
   HConstant addConstantNull(Compiler compiler) {
     return addConstant(compiler.backend.constantSystem.createNull(), compiler);
   }
 
   void finalize() {
@@ skipping 2993 matching lines @@
 class HDynamicType extends HRuntimeType {
   HDynamicType(DynamicType dartType, TypeMask instructionType)
       : super(const <HInstruction>[], dartType, instructionType);
 
   accept(HVisitor visitor) => visitor.visitDynamicType(this);
 
   int typeCode() => HInstruction.DYNAMIC_TYPE_TYPECODE;
 
   bool typeEquals(HInstruction other) => other is HDynamicType;
 }