pkg/compiler/lib/src/js_backend/codegen/js_tree_builder.dart - Issue 1198293002: dart2js: Use an abstract Name class for names in the generated JavaScript ast.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_backend/codegen/js_tree_builder.dart

Issue 1198293002: dart2js: Use an abstract Name class for names in the generated JavaScript ast. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Fix new emitter. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/compiler/lib/src/js_backend/codegen/codegen.dart ('K') | « pkg/compiler/lib/src/js_backend/codegen/glue.dart ('k') | pkg/compiler/lib/src/js_backend/constant_emitter.dart » ('j') | pkg/compiler/lib/src/js_backend/frequency_namer.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_backend/codegen/js_tree_builder.dart

diff --git a/pkg/compiler/lib/src/js_backend/codegen/js_tree_builder.dart b/pkg/compiler/lib/src/js_backend/codegen/js_tree_builder.dart

index 98893f8630bc428eeee63f59cefd720693a1d612..834e90b1719989850205a572b8c1db380b5e5bf8 100644

--- a/pkg/compiler/lib/src/js_backend/codegen/js_tree_builder.dart

+++ b/pkg/compiler/lib/src/js_backend/codegen/js_tree_builder.dart

@@ -42,8 +42,8 @@ class JsTreeBuilder extends Builder {

Expression visitInterceptor(cps_ir.Interceptor node) {

Element getInterceptor = _glue.getInterceptorMethod;

- String name = _glue.getInterceptorName(node.interceptedClasses);

- Selector selector = new Selector.call(name, null, 1);

+ // TODO(asgerf): Do not use selectors here.

+ Selector selector = new Selector.call("getInterceptor", null, 1);

floitsch 2015/06/22 17:43:44 There should be a better way to get the name of th

herhut 2015/06/23 13:26:30 You can ask the namer for a backend-name but that

_glue.registerUseInterceptorInCodegen();

return new InvokeStatic(

getInterceptor,