dart2js: Use an abstract Name class for names in the generated JavaScript ast.

pkg/compiler/lib/src/js_backend/codegen/js_tree_builder.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library js_tree_ir_builder;
 
 import '../../tree_ir/tree_ir_builder.dart' show Builder;
 import 'glue.dart' show Glue;
 import '../../dart2jslib.dart' show Selector, InternalErrorFunction;
 import '../../elements/elements.dart';
@@ skipping 24 matching lines @@
   Expression visitIdentical(cps_ir.Identical node) {
     return new InvokeStatic(
         identicalFunction,
         identicalSelector,
         <Expression>[getVariableUse(node.left),
                      getVariableUse(node.right)])..isEffectivelyConstant = true;
   }
 
   Expression visitInterceptor(cps_ir.Interceptor node) {
     Element getInterceptor = _glue.getInterceptorMethod;
-    String name = _glue.getInterceptorName(node.interceptedClasses);
-    Selector selector = new Selector.call(name, null, 1);
+    // TODO(asgerf): Do not use selectors here.
+    Selector selector = new Selector.call("getInterceptor", null, 1);

[floitsch, 2015/06/22 17:43:44]

There should be a better way to get the name of this function.

[herhut, 2015/06/23 13:26:30]

You can ask the namer for a backend-name but that will not fit into a front-end
selector. This has to and will be fixed in the tree ir.

NB: This currently breaks tests, because "getInterceptor" is wrong :)

     _glue.registerUseInterceptorInCodegen();
     return new InvokeStatic(
         getInterceptor,
         selector,
         <Expression>[getVariableUse(node.input)])..isEffectivelyConstant = true;
   }
 
   Expression visitGetField(cps_ir.GetField node) {
     return new GetField(getVariableUse(node.object), node.field);
   }
@@ skipping 15 matching lines @@
         node.classElement,
         node.arguments.map(getVariableUse).toList(growable: false),
         node.typeInformation.map(getVariableUse).toList(growable: false));
   }
 
   Expression visitCreateInvocationMirror(cps_ir.CreateInvocationMirror node) {
     return new CreateInvocationMirror(node.selector,
         node.arguments.map(getVariableUse).toList(growable: false));
   }
 }