Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(831)

Unified Diff: pkg/compiler/lib/src/js_emitter/code_emitter_task.dart

Issue 1198293002: dart2js: Use an abstract Name class for names in the generated JavaScript ast. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: fix tests Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/code_emitter_task.dart
diff --git a/pkg/compiler/lib/src/js_emitter/code_emitter_task.dart b/pkg/compiler/lib/src/js_emitter/code_emitter_task.dart
index 59fe76ae18539aa14655ccfd8bffa0443f91e259..6f3f30e3e6bfcb759d5e72812e03c21e065f9334 100644
--- a/pkg/compiler/lib/src/js_emitter/code_emitter_task.dart
+++ b/pkg/compiler/lib/src/js_emitter/code_emitter_task.dart
@@ -216,8 +216,8 @@ class CodeEmitterTask extends CompilerTask {
backend.retainMetadataOf(cls);
oldEmitter.classEmitter.visitFields(cls, false,
(Element member,
- String name,
- String accessorName,
+ jsAst.Name name,
+ jsAst.Name accessorName,
bool needsGetter,
bool needsSetter,
bool needsCheckedSetter) {

Powered by Google App Engine
This is Rietveld 408576698