pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart - Issue 1198293002: dart2js: Use an abstract Name class for names in the generated JavaScript ast.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart

Issue 1198293002: dart2js: Use an abstract Name class for names in the generated JavaScript ast. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: fix tests Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/compiler/lib/src/js_backend/codegen/codegen.dart ('K') | « pkg/compiler/lib/src/js_emitter/code_emitter_task.dart ('k') | pkg/compiler/lib/src/js_emitter/js_emitter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart

diff --git a/pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart b/pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart

index 26d9a1339816acb8b7cd1b6671fd73f86c8cec13..1da1a032e8a139e1038df5c229835bf24c900560 100644

--- a/pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart

+++ b/pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart

@@ -287,11 +287,11 @@ class InterceptorStubGenerator {

return null;

}

- jsAst.Expression generateOneShotInterceptor(String name) {

+ jsAst.Expression generateOneShotInterceptor(jsAst.Name name) {

Selector selector = backend.oneShotInterceptors[name];

Set<ClassElement> classes =

backend.getInterceptedClassesOn(selector.name);

- String getInterceptorName = namer.nameForGetInterceptor(classes);

+ jsAst.Name getInterceptorName = namer.nameForGetInterceptor(classes);

List<String> parameterNames = <String>[];

parameterNames.add('receiver');

@@ -304,7 +304,7 @@ class InterceptorStubGenerator {

}

- String invocationName = backend.namer.invocationName(selector);

+ jsAst.Name invocationName = backend.namer.invocationName(selector);

String globalObject = namer.globalObjectFor(backend.interceptorsLibrary);

jsAst.Statement optimizedPath =