src/IceCompileServer.cpp - Issue 1197863003: Subzero: Reduce the amount of #ifdef'd code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceCompileServer.cpp

Issue 1197863003: Subzero: Reduce the amount of #ifdef'd code. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Use constexpr inline functions instead of macros Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceCompileServer.cpp

diff --git a/src/IceCompileServer.cpp b/src/IceCompileServer.cpp

index 44563439521b42b98723eda1a9590a74e93c1d28..4ee56f2b6b0d1bcb8450f1ae993294463065a205 100644

--- a/src/IceCompileServer.cpp

+++ b/src/IceCompileServer.cpp

@@ -98,7 +98,7 @@ ErrorCodes getReturnValue(const Ice::ClFlagsExtra &Flags, ErrorCodes Val) {

} // end of anonymous namespace

void CLCompileServer::run() {

- if (ALLOW_DUMP) {

+ if (buildAllowsDump()) {

llvm::sys::PrintStackTraceOnErrorSignal();

}

ClFlags::parseFlags(argc, argv);

« src/IceAssemblerX8632.cpp ('K') | « src/IceClFlags.cpp ('k') | src/IceCompiler.cpp » ('j') | src/IceDefs.h » ('J')