content/renderer/notification_permission_dispatcher.cc - Issue 1197853005: Collecting statistics on iframe permissions use.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/notification_permission_dispatcher.cc

Issue 1197853005: Collecting statistics on iframe permissions use. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed NOTREACHED calls. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/notification_permission_dispatcher.cc

diff --git a/content/renderer/notification_permission_dispatcher.cc b/content/renderer/notification_permission_dispatcher.cc

index 90eef27cf7787f650bbbe87a4e7910ba8acad42a..d0c1617edb7b0343e11875466f1b1b5b7a230b17 100644

--- a/content/renderer/notification_permission_dispatcher.cc

+++ b/content/renderer/notification_permission_dispatcher.cc

@@ -58,6 +58,8 @@ void NotificationPermissionDispatcher::OnPermissionRequestComplete(

case PERMISSION_STATUS_ASK:

permission = blink::WebNotificationPermissionDefault;

break;

+ case PERMISSION_STATUS_NUM:

+ return;

}

callback->permissionRequestComplete(permission);