chrome/browser/content_settings/permission_context_uma_util.h - Issue 1197853005: Collecting statistics on iframe permissions use.

Unified Diff: chrome/browser/content_settings/permission_context_uma_util.h

Issue 1197853005: Collecting statistics on iframe permissions use. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/content_settings/permission_context_uma_util.h

diff --git a/chrome/browser/content_settings/permission_context_uma_util.h b/chrome/browser/content_settings/permission_context_uma_util.h

index 8d769aeb2268f5192a963f2b755a0bd522c625a8..90b6ba0a24c0a8786561b7929eed02f003e78356 100644

--- a/chrome/browser/content_settings/permission_context_uma_util.h

+++ b/chrome/browser/content_settings/permission_context_uma_util.h

@@ -6,6 +6,7 @@

#define CHROME_BROWSER_CONTENT_SETTINGS_PERMISSION_CONTEXT_UMA_UTIL_H_

#include "base/logging.h"

+#include "components/content_settings/core/browser/host_content_settings_map.h"

mlamouri (slow - plz ping) 2015/06/22 22:10:57 I think you could forward declare instead of inclu

keenanb 2015/06/24 22:26:11 forward declaring causes "member access into incom

#include "components/content_settings/core/common/content_settings_types.h"

class GURL;

@@ -14,14 +15,17 @@ class GURL;

// operations.

class PermissionContextUmaUtil {

public:

+ static void PermissionRequested(

jww 2015/06/23 05:32:58 Is there a particular reason you reordered this?

keenanb 2015/06/24 22:26:11 a permission request is different from a user's pe

+ ContentSettingsType permission,

+ HostContentSettingsMap* hostContentSettingsMap,

mlamouri (slow - plz ping) 2015/06/22 22:10:57 style: host_content_settings_map

keenanb 2015/06/24 22:26:11 Done.

+ const GURL& requesting_origin,

+ const GURL& embedding_origin);

static void PermissionGranted(ContentSettingsType permission,

const GURL& requesting_origin);

static void PermissionDenied(ContentSettingsType permission,

const GURL& requesting_origin);

static void PermissionDismissed(ContentSettingsType permission,

const GURL& requesting_origin);

- static void PermissionRequested(ContentSettingsType permission,

- const GURL& requesting_origin);

static void PermissionIgnored(ContentSettingsType permission,

const GURL& requesting_origin);