Collecting statistics on iframe permissions use.

chrome/browser/content_settings/permission_context_uma_util.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CONTENT_SETTINGS_PERMISSION_CONTEXT_UMA_UTIL_H_
 #define CHROME_BROWSER_CONTENT_SETTINGS_PERMISSION_CONTEXT_UMA_UTIL_H_
 
 #include "base/logging.h"
+#include "components/content_settings/core/browser/host_content_settings_map.h"

[mlamouri (slow - plz ping), 2015/06/22 22:10:57]

I think you could forward declare instead of including here.

[keenanb, 2015/06/24 22:26:11]

forward declaring causes "member access into incomplete type".

 #include "components/content_settings/core/common/content_settings_types.h"
 
 class GURL;
 
 // Provides a convenient way of logging UMA for permission related
 // operations.
 class PermissionContextUmaUtil {
  public:
+  static void PermissionRequested(

[jww, 2015/06/23 05:32:58]

Is there a particular reason you reordered this?

[keenanb, 2015/06/24 22:26:11]

a permission request is different from a user's permission action.

+      ContentSettingsType permission,
+      HostContentSettingsMap* hostContentSettingsMap,

[mlamouri (slow - plz ping), 2015/06/22 22:10:57]

style: host_content_settings_map

[keenanb, 2015/06/24 22:26:11]

Done.

+      const GURL& requesting_origin,
+      const GURL& embedding_origin);
   static void PermissionGranted(ContentSettingsType permission,
                                 const GURL& requesting_origin);
   static void PermissionDenied(ContentSettingsType permission,
                                const GURL& requesting_origin);
   static void PermissionDismissed(ContentSettingsType permission,
                                   const GURL& requesting_origin);
-  static void PermissionRequested(ContentSettingsType permission,
-                                  const GURL& requesting_origin);
   static void PermissionIgnored(ContentSettingsType permission,
                                 const GURL& requesting_origin);
 
  private:
   DISALLOW_IMPLICIT_CONSTRUCTORS(PermissionContextUmaUtil);
 };
 
 #endif  // CHROME_BROWSER_CONTENT_SETTINGS_PERMISSION_CONTEXT_UMA_UTIL_H_