Issue 119763003: Add more directories to _CheckForString16() whitelist.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 119763003: Add more directories to _CheckForString16() whitelist. (Closed)

Created:
7 years ago by Dan Beam

Modified:
7 years ago

Reviewers:
Jói

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add more directories to _CheckForString16() whitelist. TBR=joi@chromium.org BUG=329295 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242052

Patch Set 1 #

Patch Set 2 : chrome/ #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	PRESUBMIT.py	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Dan Beam

depends on https://codereview.chromium.org/118953002/ landing first

7 years ago (2013-12-20 05:21:05 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/119763003/20001

7 years ago (2013-12-20 09:12:01 UTC) #3

Jói

7 years ago (2013-12-20 12:13:15 UTC) #5

LGTM


On Fri, Dec 20, 2013 at 5:21 AM, <dbeam@chromium.org> wrote:

> Reviewers: Jói,
>
> Message:
> depends on https://codereview.chromium.org/118953002/ landing first
>
> Description:
> Add content/ to _CheckForString16() whitelist.
>
> TBR=joi@chromium.org
> BUG=329295
> NOTRY=true
>
> Please review this at https://codereview.chromium.org/119763003/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files (+1, -0 lines):
>   M PRESUBMIT.py
>
>
> Index: PRESUBMIT.py
> diff --git a/PRESUBMIT.py b/PRESUBMIT.py
> index 413f3634e3f3b315abf0c6959dfac975c195c132..
> df305fe424624d2bfb78ad05f4faf3d915054814 100644
> --- a/PRESUBMIT.py
> +++ b/PRESUBMIT.py
> @@ -1193,6 +1193,7 @@ def _CheckForString16(input_api, output_api):
>            r'^chrome[\\\/]browser[\\\/]',
>            r'^chromeos[\\\/]',
>            r'^components[\\\/]',
> +          r'^content[\\\/]',
>            r'^device[\\\/]',
>            r'^ipc[\\\/]',
>            r'^net[\\\/]',
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Expand Messages | Collapse Messages