Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: PRESUBMIT.py

Issue 119763003: Add more directories to _CheckForString16() whitelist. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: chrome/ Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 1172 matching lines...) Expand 10 before | Expand all | Expand 10 after
1183 results.append(' %s:%d' % (f.LocalPath(), lnum)) 1183 results.append(' %s:%d' % (f.LocalPath(), lnum))
1184 return results 1184 return results
1185 1185
1186 1186
1187 def _CheckForString16(input_api, output_api): 1187 def _CheckForString16(input_api, output_api):
1188 file_filter = lambda f: input_api.FilterSourceFile(f, 1188 file_filter = lambda f: input_api.FilterSourceFile(f,
1189 white_list=( 1189 white_list=(
1190 r'^android_webview[\\\/]', 1190 r'^android_webview[\\\/]',
1191 r'^apps[\\\/]', 1191 r'^apps[\\\/]',
1192 r'^ash[\\\/]', 1192 r'^ash[\\\/]',
1193 r'^chrome[\\\/]browser[\\\/]', 1193 r'^chrome[\\\/]',
1194 r'^chromeos[\\\/]', 1194 r'^chromeos[\\\/]',
1195 r'^components[\\\/]', 1195 r'^components[\\\/]',
1196 r'^content[\\\/]',
1196 r'^device[\\\/]', 1197 r'^device[\\\/]',
1197 r'^ipc[\\\/]', 1198 r'^ipc[\\\/]',
1198 r'^net[\\\/]', 1199 r'^net[\\\/]',
1199 r'^ppapi[\\\/]', 1200 r'^ppapi[\\\/]',
1200 r'^printing[\\\/]', 1201 r'^printing[\\\/]',
1201 r'^rlz[\\\/]', 1202 r'^rlz[\\\/]',
1202 r'^skia[\\\/]', 1203 r'^skia[\\\/]',
1203 r'^tools[\\\/]', 1204 r'^tools[\\\/]',
1204 r'^ui[\\\/]', 1205 r'^ui[\\\/]',
1205 r'^webkit[\\\/]', 1206 r'^webkit[\\\/]',
(...skipping 261 matching lines...) Expand 10 before | Expand all | Expand 10 after
1467 trybots.extend(GetDefaultTryConfigs(['cros_x86'])) 1468 trybots.extend(GetDefaultTryConfigs(['cros_x86']))
1468 1469
1469 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it 1470 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it
1470 # unless they're .gyp(i) files as changes to those files can break the gyp 1471 # unless they're .gyp(i) files as changes to those files can break the gyp
1471 # step on that bot. 1472 # step on that bot.
1472 if (not all(re.search('^chrome', f) for f in files) or 1473 if (not all(re.search('^chrome', f) for f in files) or
1473 any(re.search('\.gypi?$', f) for f in files)): 1474 any(re.search('\.gypi?$', f) for f in files)):
1474 trybots.extend(GetDefaultTryConfigs(['android_aosp'])) 1475 trybots.extend(GetDefaultTryConfigs(['android_aosp']))
1475 1476
1476 return trybots 1477 return trybots
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698