Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 119753008: Revert r18451 "Revert r18449 "Reland r18383: More API cleanup." and r18450 "Unbreak build."" since … (Closed)

Created:
6 years, 11 months ago by ulan
Modified:
6 years, 11 months ago
Reviewers:
Sven Panne
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert r18451 "Revert r18449 "Reland r18383: More API cleanup." and r18450 "Unbreak build."" since necessary WebKit changes are rolled in Chromium. TBR=svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=18452

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+702 lines, -638 lines) Patch
M include/v8.h View 7 chunks +3 lines, -18 lines 0 comments Download
M src/api.cc View 11 chunks +11 lines, -62 lines 0 comments Download
M src/d8-posix.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/extensions/statistics-extension.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/cctest.h View 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/profiler-extension.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M test/cctest/test-accessors.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-api.cc View 161 chunks +435 lines, -372 lines 0 comments Download
M test/cctest/test-assembler-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-assembler-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-cpu-profiler.cc View 12 chunks +34 lines, -14 lines 0 comments Download
M test/cctest/test-debug.cc View 38 chunks +79 lines, -58 lines 0 comments Download
M test/cctest/test-declarative-accessors.cc View 2 chunks +9 lines, -7 lines 0 comments Download
M test/cctest/test-decls.cc View 20 chunks +46 lines, -36 lines 0 comments Download
M test/cctest/test-global-handles.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-global-object.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-heap.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 5 chunks +13 lines, -8 lines 0 comments Download
M test/cctest/test-object-observe.cc View 8 chunks +35 lines, -30 lines 0 comments Download
M test/cctest/test-strings.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M test/cctest/test-thread-termination.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ulan
Committed patchset #1 manually as r18452 (presubmit successful).
6 years, 11 months ago (2014-01-03 14:31:35 UTC) #1
Sven Panne
6 years, 11 months ago (2014-01-03 20:06:19 UTC) #2
Message was sent while issue was closed. 
Alas, Chrome and Blink need 2 more changes:

   https://codereview.chromium.org/122073003/
   https://codereview.chromium.org/124103003/

It would be great if the v8 changes were kept, otherwise I'm caught in an
eternal loop... :-P Our current workflow doesn't really handle interface
changes, enough damaging changes are done on the Chome/Blink side while we are
doing the roll-revert-dance. The only sane solution I see is that we'll forcibly
push any API changes through to Chrome, ignoring our own waterfall, and 'git cl
dcommit' any necessary changes on the Chrome/Blink side until the tree is green
again (probably while the west coast sheriffs are sleeping ;-). The current
state of affairs is depressing and a waste of time... :-(

Powered by Google App Engine
This is Rietveld 408576698