Issue 11975038: Implement rough new Views task manager style.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11975038: Implement rough new Views task manager style. (Closed)

Created:
7 years, 11 months ago by msw

Modified:
7 years, 11 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, yoshiki+watch_chromium.org, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Implement rough new Views task manager style. When --enable-new-dialog-style is specified: 1) Remove the standard task manager frame and allow the 2) Use the non-native button styling (via LabelButton). 3) TODO: Use table_view_views or support transparency with table_view_win. 4) TODO: Use LabelButton ("Views Style") or "Chrome Style" for buttons? ( see pics at http://crbug.com/166075#c14 and http://crbug.com/166075#c16 ) Minor dialog layout refactoring, comment typo fix. BUG=166075 TEST=Task Manager looks closer to the new dialog style. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177515

Patch Set 1 #

Patch Set 2 : Use 'Chrome Style' TextButtons instead. #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -5 lines)			Patch
M	chrome/browser/ui/views/task_manager_view.cc	View	1	3 chunks	+18 lines, -1 line	0 comments	Download
M	ui/views/widget/widget.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/window/dialog_frame_view.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

msw

Hey Scott, please take a look; which button do you think looks better? (I'd say ...

7 years, 11 months ago (2013-01-17 17:18:00 UTC) #1

sky

LGTM - See 170370 for making the task manager using TableViewViews. Hopefully I can finish ...

7 years, 11 months ago (2013-01-17 17:29:38 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/11975038/4001

7 years, 11 months ago (2013-01-17 17:58:37 UTC) #3

Message was sent while issue was closed.

Change committed as 177515

Expand Messages | Collapse Messages