chrome/browser/chromeos/settings/device_settings_provider.h - Issue 11975009: Prevent a DCHECK when starting a chromeos=1 build with --stub-cros-settings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/settings/device_settings_provider.h

Issue 11975009: Prevent a DCHECK when starting a chromeos=1 build with --stub-cros-settings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: share setting names list Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chromeos/settings/device_settings_provider.h

diff --git a/chrome/browser/chromeos/settings/device_settings_provider.h b/chrome/browser/chromeos/settings/device_settings_provider.h

index 6ebf20046821e6338369cde89d420ac990f12da3..a6041359d67283fc055f099ef8a5c4498071303f 100644

--- a/chrome/browser/chromeos/settings/device_settings_provider.h

+++ b/chrome/browser/chromeos/settings/device_settings_provider.h

@@ -37,6 +37,10 @@ class DeviceSettingsProvider : public CrosSettingsProvider,

DeviceSettingsService* device_settings_service);

virtual ~DeviceSettingsProvider();

+ // These pointers range over the setting names known to this provider.

+ static const char** kKnownSettingsBegin;

+ static const char** kKnownSettingsEnd;

Mattias Nissler (ping if slow) 2013/01/16 14:48:36 thinking about it, can't we just make this static

Joao da Silva 2013/01/16 15:10:08 Uh, of course. *main brain turn on* Done.

// CrosSettingsProvider implementation.

virtual const base::Value* Get(const std::string& path) const OVERRIDE;

virtual TrustedStatus PrepareTrustedValues(

« no previous file with comments | « no previous file | chrome/browser/chromeos/settings/device_settings_provider.cc » ('j') | no next file with comments »