Prevent a DCHECK when starting a chromeos=1 build with --stub-cros-settings.

chrome/browser/chromeos/settings/device_settings_provider.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_SETTINGS_DEVICE_SETTINGS_PROVIDER_H_
 #define CHROME_BROWSER_CHROMEOS_SETTINGS_DEVICE_SETTINGS_PROVIDER_H_
 
 #include <deque>
 #include <string>
 #include <utility>
@@ skipping 19 matching lines @@
 namespace chromeos {
 
 // CrosSettingsProvider implementation that works with device settings.
 class DeviceSettingsProvider : public CrosSettingsProvider,
                                public DeviceSettingsService::Observer {
  public:
   DeviceSettingsProvider(const NotifyObserversCallback& notify_cb,
                          DeviceSettingsService* device_settings_service);
   virtual ~DeviceSettingsProvider();
 
+  // These pointers range over the setting names known to this provider.
+  static const char** kKnownSettingsBegin;
+  static const char** kKnownSettingsEnd;

[Mattias Nissler (ping if slow), 2013/01/16 14:48:36]

thinking about it, can't we just make this

static bool* IsDeviceSetting(const std::string& path)

[Joao da Silva, 2013/01/16 15:10:08]

Uh, of course.

*main brain turn on*

Done.

+
   // CrosSettingsProvider implementation.
   virtual const base::Value* Get(const std::string& path) const OVERRIDE;
   virtual TrustedStatus PrepareTrustedValues(
       const base::Closure& callback) OVERRIDE;
   virtual bool HandlesSetting(const std::string& path) const OVERRIDE;
 
  private:
   // CrosSettingsProvider implementation:
   virtual void DoSet(const std::string& path,
                      const base::Value& value) OVERRIDE;
@@ skipping 107 matching lines @@
                            InitializationTestUnowned);
   FRIEND_TEST_ALL_PREFIXES(DeviceSettingsProviderTest,
                            PolicyFailedPermanentlyNotification);
   FRIEND_TEST_ALL_PREFIXES(DeviceSettingsProviderTest, PolicyLoadNotification);
   DISALLOW_COPY_AND_ASSIGN(DeviceSettingsProvider);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_SETTINGS_DEVICE_SETTINGS_PROVIDER_H_