Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 11975007: Implement one-page-at-a-time mousewheel scrolling in the impl thread. (Closed)

Created:
7 years, 11 months ago by Vangelis Kokkevis
Modified:
7 years, 8 months ago
Reviewers:
jamesr, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Implement one-page-at-a-time mousewheel scrolling in the impl thread. Previously the scrollByPage setting in the incoming scroll event was getting ignored. BUG=160122

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -6 lines) Patch
M cc/input_handler.h View 1 chunk +3 lines, -1 line 0 comments Download
M cc/layer.h View 2 chunks +4 lines, -0 lines 0 comments Download
M cc/layer.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M cc/layer_impl.h View 2 chunks +5 lines, -1 line 0 comments Download
M cc/layer_impl.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M cc/layer_tree_host_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layer_tree_host_impl.cc View 3 chunks +13 lines, -1 line 1 comment Download
M webkit/compositor_bindings/web_layer_impl.h View 1 chunk +2 lines, -0 lines 1 comment Download
M webkit/compositor_bindings/web_layer_impl.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M webkit/compositor_bindings/web_to_ccinput_handler_adapter.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
enne (OOO)
What about one-pixel-at-a-time? Aren't there three states to that enum?
7 years, 11 months ago (2013-01-16 17:26:03 UTC) #1
jamesr
The logic to do scrollByPage in WebCore seems to be different. Looking at https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/WebCore/platform/ScrollView.cpp&q=pageStep&sq=package:chromium&type=cs&l=567, it's ...
7 years, 9 months ago (2013-03-06 23:50:37 UTC) #2
vangelis
On 2013/01/16 17:26:03, enne wrote: > What about one-pixel-at-a-time? Aren't there three states to that ...
7 years, 9 months ago (2013-03-07 02:01:21 UTC) #3
jamesr
The determination of whether a wheel is pixel-accurate or represents logical lines happens earlier, in ...
7 years, 9 months ago (2013-03-07 03:02:50 UTC) #4
enne (OOO)
7 years, 8 months ago (2013-04-01 16:20:30 UTC) #5
Closing this code review, as jamesr's https://codereview.chromium.org/12582009
implemented this.

Powered by Google App Engine
This is Rietveld 408576698