Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1197403002: Global handle leak in Realm.create() fixed. (Closed)

Created:
5 years, 6 months ago by Igor Sheludko
Modified:
5 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Global handle leak in Realm.create() fixed. BUG=chromium:501808 LOG=N Committed: https://crrev.com/5c4aae390fa589a3821ca2e7e9d10677b4850bd2 Cr-Commit-Position: refs/heads/master@{#29224}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/d8.cc View 1 chunk +1 line, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-501808.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Igor Sheludko
PTAL
5 years, 6 months ago (2015-06-23 10:30:31 UTC) #3
Jakob Kummerow
LGTM.
5 years, 6 months ago (2015-06-23 10:33:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1197403002/20001
5 years, 6 months ago (2015-06-23 10:34:27 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 6 months ago (2015-06-23 11:04:18 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-23 11:04:30 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c4aae390fa589a3821ca2e7e9d10677b4850bd2
Cr-Commit-Position: refs/heads/master@{#29224}

Powered by Google App Engine
This is Rietveld 408576698