Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: src/d8.cc

Issue 1197403002: Global handle leak in Realm.create() fixed. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-501808.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/d8.cc
diff --git a/src/d8.cc b/src/d8.cc
index c46df53851a5fef9e39d1b02c829d8d7073a4308..624e420f9b3cb07e2131cd93b5c3924a159d2c41 100644
--- a/src/d8.cc
+++ b/src/d8.cc
@@ -480,6 +480,7 @@ void Shell::RealmCreate(const v8::FunctionCallbackInfo<v8::Value>& args) {
data->realms_ = new Persistent<Context>[++data->realm_count_];
for (int i = 0; i < index; ++i) {
data->realms_[i].Reset(isolate, old_realms[i]);
+ old_realms[i].Reset();
}
delete[] old_realms;
Handle<ObjectTemplate> global_template = CreateGlobalTemplate(isolate);
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-501808.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698