Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 1197383002: Add WebLocalFrame::effectiveSandboxFlags() (Closed)

Created:
5 years, 6 months ago by horo
Modified:
5 years, 6 months ago
Reviewers:
kinuko, tkent
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add WebLocalFrame::effectiveSandboxFlags() We will use it while creating ServiceWorkerNetworkProvider in RenderFrameImpl::didCreateDataSource(). See https://codereview.chromium.org/1191293002/. BUG=486308 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197698

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M Source/web/WebLocalFrameImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M public/web/WebLocalFrame.h View 2 chunks +5 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (7 generated)
horo
kinuko@ Could you please review this?
5 years, 6 months ago (2015-06-23 10:32:51 UTC) #2
kinuko
lgtm
5 years, 6 months ago (2015-06-23 10:45:51 UTC) #3
horo
tkent@ Could you please review this? Thank you.
5 years, 6 months ago (2015-06-23 23:21:34 UTC) #5
tkent
lgtm
5 years, 6 months ago (2015-06-23 23:37:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1197383002/1
5 years, 6 months ago (2015-06-23 23:37:50 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/60455)
5 years, 6 months ago (2015-06-24 00:59:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1197383002/1
5 years, 6 months ago (2015-06-24 01:14:08 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/60479)
5 years, 6 months ago (2015-06-24 02:33:08 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1197383002/1
5 years, 6 months ago (2015-06-24 03:40:44 UTC) #16
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 04:18:40 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197698

Powered by Google App Engine
This is Rietveld 408576698