Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 119733002: Add base:: to string16s in win8/. (Closed)

Created:
7 years ago by Dan Beam
Modified:
7 years ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : nits #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+240 lines, -227 lines) Patch
M win8/delegate_execute/chrome_util.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M win8/delegate_execute/command_execute_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M win8/delegate_execute/command_execute_impl.cc View 1 6 chunks +7 lines, -7 lines 0 comments Download
M win8/delegate_execute/crash_server_init.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M win8/delegate_execute/delegate_execute.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M win8/delegate_execute/delegate_execute_operation.h View 2 chunks +4 lines, -4 lines 0 comments Download
M win8/delegate_execute/delegate_execute_operation.cc View 1 chunk +1 line, -1 line 0 comments Download
M win8/delegate_execute/delegate_execute_util.h View 1 chunk +2 lines, -2 lines 0 comments Download
M win8/delegate_execute/delegate_execute_util.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M win8/delegate_execute/delegate_execute_util_unittest.cc View 1 1 chunk +12 lines, -9 lines 0 comments Download
M win8/metro_driver/chrome_app_view.h View 2 chunks +3 lines, -3 lines 0 comments Download
M win8/metro_driver/chrome_app_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M win8/metro_driver/chrome_app_view_ash.h View 3 chunks +9 lines, -8 lines 0 comments Download
M win8/metro_driver/chrome_app_view_ash.cc View 1 2 13 chunks +17 lines, -16 lines 0 comments Download
M win8/metro_driver/chrome_url_launch_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M win8/metro_driver/chrome_url_launch_handler.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M win8/metro_driver/file_picker.cc View 9 chunks +15 lines, -13 lines 0 comments Download
M win8/metro_driver/file_picker_ash.h View 7 chunks +10 lines, -10 lines 0 comments Download
M win8/metro_driver/file_picker_ash.cc View 13 chunks +21 lines, -19 lines 0 comments Download
M win8/metro_driver/ime/text_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M win8/metro_driver/ime/text_service_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M win8/metro_driver/ime/text_store.h View 1 chunk +1 line, -1 line 0 comments Download
M win8/metro_driver/ime/text_store.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M win8/metro_driver/ime/text_store_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M win8/metro_driver/metro_dialog_box.h View 1 chunk +4 lines, -4 lines 0 comments Download
M win8/metro_driver/metro_dialog_box.cc View 1 chunk +1 line, -1 line 0 comments Download
M win8/metro_driver/metro_driver.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M win8/metro_driver/secondary_tile.h View 1 chunk +5 lines, -5 lines 0 comments Download
M win8/metro_driver/secondary_tile.cc View 6 chunks +11 lines, -10 lines 0 comments Download
M win8/metro_driver/toast_notification_handler.h View 1 chunk +4 lines, -4 lines 0 comments Download
M win8/metro_driver/toast_notification_handler.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M win8/metro_driver/winrt_utils.h View 2 chunks +3 lines, -3 lines 0 comments Download
M win8/metro_driver/winrt_utils.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M win8/test/metro_registration_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M win8/test/open_with_dialog_async.h View 1 chunk +2 lines, -2 lines 0 comments Download
M win8/test/open_with_dialog_async.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M win8/test/open_with_dialog_controller.h View 3 chunks +7 lines, -7 lines 0 comments Download
M win8/test/open_with_dialog_controller.cc View 8 chunks +17 lines, -17 lines 0 comments Download
M win8/test/test_registrar.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M win8/test/ui_automation_client.h View 2 chunks +3 lines, -2 lines 0 comments Download
M win8/test/ui_automation_client.cc View 10 chunks +13 lines, -13 lines 0 comments Download
M win8/viewer/metro_viewer_process_host.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Dan Beam
7 years ago (2013-12-20 03:38:48 UTC) #1
grt (UTC plus 2)
lgtm
7 years ago (2013-12-20 15:00:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/119733002/20001
7 years ago (2013-12-20 15:01:18 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=42476
7 years ago (2013-12-20 15:16:04 UTC) #4
Dan Beam
7 years ago (2013-12-20 17:36:36 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 manually as r242114.

Powered by Google App Engine
This is Rietveld 408576698