Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: win8/delegate_execute/delegate_execute_util_unittest.cc

Issue 119733002: Add base:: to string16s in win8/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « win8/delegate_execute/delegate_execute_util.cc ('k') | win8/metro_driver/chrome_app_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: win8/delegate_execute/delegate_execute_util_unittest.cc
diff --git a/win8/delegate_execute/delegate_execute_util_unittest.cc b/win8/delegate_execute/delegate_execute_util_unittest.cc
index f01b15757bf6da019a7f0b08bd8b3cabe59e5be7..ca444b80db3303ba35f35a5965f7dac690c7f629 100644
--- a/win8/delegate_execute/delegate_execute_util_unittest.cc
+++ b/win8/delegate_execute/delegate_execute_util_unittest.cc
@@ -42,38 +42,41 @@ TEST(DelegateExecuteUtil, MakeChromeCommandLineTest) {
// Empty params and argument contains only the exe.
cl = delegate_execute::MakeChromeCommandLine(
- this_exe, delegate_execute::CommandLineFromParameters(NULL), string16());
+ this_exe,
+ delegate_execute::CommandLineFromParameters(NULL),
+ base::string16());
EXPECT_EQ(1, cl.argv().size());
EXPECT_EQ(this_exe.value(), cl.GetProgram().value());
// Empty params with arg contains the arg.
cl = delegate_execute::MakeChromeCommandLine(
this_exe, delegate_execute::CommandLineFromParameters(NULL),
- string16(kSomeArgument));
+ base::string16(kSomeArgument));
EXPECT_EQ(2, cl.argv().size());
EXPECT_EQ(this_exe.value(), cl.GetProgram().value());
EXPECT_EQ(1, cl.GetArgs().size());
- EXPECT_EQ(string16(kSomeArgument), cl.GetArgs()[0]);
+ EXPECT_EQ(base::string16(kSomeArgument), cl.GetArgs()[0]);
// Params with switchs and args plus arg contains the arg.
cl = delegate_execute::MakeChromeCommandLine(
this_exe, delegate_execute::CommandLineFromParameters(
base::StringPrintf(L"--%ls -- %ls", ASCIIToWide(kSomeSwitch).c_str(),
kOtherArgument).c_str()),
- string16(kSomeArgument));
+ base::string16(kSomeArgument));
EXPECT_EQ(5, cl.argv().size());
EXPECT_EQ(this_exe.value(), cl.GetProgram().value());
EXPECT_TRUE(cl.HasSwitch(kSomeSwitch));
CommandLine::StringVector args(cl.GetArgs());
EXPECT_EQ(2, args.size());
+ EXPECT_NE(
+ args.end(),
+ std::find(args.begin(), args.end(), base::string16(kOtherArgument)));
EXPECT_NE(args.end(),
- std::find(args.begin(), args.end(), string16(kOtherArgument)));
- EXPECT_NE(args.end(),
- std::find(args.begin(), args.end(), string16(kSomeArgument)));
+ std::find(args.begin(), args.end(), base::string16(kSomeArgument)));
}
TEST(DelegateExecuteUtil, ParametersFromSwitchTest) {
- EXPECT_EQ(string16(), delegate_execute::ParametersFromSwitch(NULL));
- EXPECT_EQ(string16(L"--some-switch"),
+ EXPECT_EQ(base::string16(), delegate_execute::ParametersFromSwitch(NULL));
+ EXPECT_EQ(base::string16(L"--some-switch"),
delegate_execute::ParametersFromSwitch(kSomeSwitch));
}
« no previous file with comments | « win8/delegate_execute/delegate_execute_util.cc ('k') | win8/metro_driver/chrome_app_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698