remoting/host/desktop_process_entry.h - Issue 11970044: Merged all Chromoting Host code into remoting_core.dll (Windows).

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/host/desktop_process_entry.h

Issue 11970044: Merged all Chromoting Host code into remoting_core.dll (Windows). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: host_ui_resource.h has been deleted. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef REMOTING_HOST_DESKTOP_PROCESS_ENTRY_H_

	6 #define REMOTING_HOST_DESKTOP_PROCESS_ENTRY_H_

	7

	8 #include "remoting/host/host_export.h"

	9

	10 namespace remoting {

	11

	12 // The desktop process's entry point.

	13 HOST_EXPORT int RunDesktopProcess(int argc, char** argv);
	Sergey Ulanov 2013/01/18 21:14:55 Maybe call it DesktopProcessMain()? Maybe call it DesktopProcessMain()? alexeypa (please no reviews) 2013/01/18 22:06:10 There is already DesktopProcessMain() in remoting/ Show quoted text On 2013/01/18 21:14:55, sergeyu wrote: > Maybe call it DesktopProcessMain()? There is already DesktopProcessMain() in remoting/host/win/desktop_process_main.cc. The logic here is that RunXxx is exported from remoting_core.dll. XxxMain is specified as an entry point in the EXE wrapper. Sergey Ulanov 2013/01/24 20:02:11 I suggest that you rename DaemonProcessMain() to D Show quoted text On 2013/01/18 22:06:10, alexeypa wrote: > On 2013/01/18 21:14:55, sergeyu wrote: > > Maybe call it DesktopProcessMain()? > > There is already DesktopProcessMain() in > remoting/host/win/desktop_process_main.cc. The logic here is that RunXxx is > exported from remoting_core.dll. XxxMain is specified as an entry point in the > EXE wrapper. I suggest that you rename DaemonProcessMain() to DaemonProcessEntryPoint(), and call this DesktopProcessMain(). Also note that they are in different namespaces so they could have the same name (but I'm not suggesting doing it). alexeypa (please no reviews) 2013/01/28 21:57:29 Done. Show quoted text On 2013/01/24 20:02:11, sergeyu wrote: > On 2013/01/18 22:06:10, alexeypa wrote: > > On 2013/01/18 21:14:55, sergeyu wrote: > > > Maybe call it DesktopProcessMain()? > > > > There is already DesktopProcessMain() in > > remoting/host/win/desktop_process_main.cc. The logic here is that RunXxx is > > exported from remoting_core.dll. XxxMain is specified as an entry point in the > > EXE wrapper. > > I suggest that you rename DaemonProcessMain() to DaemonProcessEntryPoint(), and > call this DesktopProcessMain(). Also note that they are in different namespaces > so they could have the same name (but I'm not suggesting doing it). Done.
	14

	15 } // namespace remoting

	16

	17 #endif // REMOTING_HOST_DESKTOP_PROCESS_ENTRY_H_

OLD	NEW

« remoting/branding_Chromium ('K') | « remoting/host/continue_window_win.cc ('k') | remoting/host/desktop_process_entry.cc » ('j') | remoting/host/win/daemon_process_main.cc » ('J')