Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 11970041: Merge 139461 (Closed)

Created:
7 years, 11 months ago by Xianzhu
Modified:
7 years, 11 months ago
Reviewers:
Xianzhu
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1364/
Visibility:
Public.

Description

Merge 139461 > RenderLayerCompositor should let ScrollingCoordinator update main thread scrolling reasons after change of layers > https://bugs.webkit.org/show_bug.cgi?id=105652 > > Reviewed by Simon Fraser. > > Source/WebCore: > > Let ScrollingCoordinator know the change of ViewportConstrainedNotCompositedReason in time. > By the way moved RenderLayerCompositor::FixedPositionLayerNotCompositedReason to RenderLayer::ViewportConstrainedNotCompositedReason. > > Tests: compositing/layer-creation/fixed-position-in-view-dynamic.html > compositing/layer-creation/fixed-position-out-of-view-dynamic.html > > * page/scrolling/ScrollingCoordinator.cpp: > (WebCore::ScrollingCoordinator::hasVisibleSlowRepaintViewportConstrainedObjects): > (WebCore::ScrollingCoordinator::mainThreadScrollingReasons): > (WebCore::ScrollingCoordinator::mainThreadScrollingReasonsAsText): > * page/scrolling/ScrollingCoordinator.h: > (ScrollingCoordinator): > * page/scrolling/mac/ScrollingCoordinatorMac.h: > (WebCore::ScrollingCoordinatorMac::hasVisibleSlowRepaintViewportConstrainedObjects): > * page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm: > (WebCore::logThreadedScrollingMode): > * rendering/RenderLayer.cpp: > (WebCore::RenderLayer::RenderLayer): > (WebCore::RenderLayer::paintLayer): > * rendering/RenderLayer.h: > (RenderLayer): Moved RenderLayerCompositor::FixedPositionLayerNotCompositedReason to here and renamed it to ViewportConstrainedNotCompositedReason. > (WebCore::RenderLayer::setViewportConstrainedNotCompositedReason): > (WebCore::RenderLayer::viewportConstrainedNotCompositedReason): > * rendering/RenderLayerCompositor.cpp: > (WebCore::RenderLayerCompositor::updateCompositingLayers): > (WebCore::RenderLayerCompositor::updateBacking): Now updates ViewportConstrainedNotCompositedReason here instead of in computeCompositingRequirements before so that the reason is updated in time. > (WebCore::RenderLayerCompositor::computeCompositingRequirements): > (WebCore::RenderLayerCompositor::needsToBeComposited): > (WebCore::RenderLayerCompositor::requiresCompositingLayer): > (WebCore::RenderLayerCompositor::reasonForCompositing): > (WebCore::RenderLayerCompositor::requiresCompositingForPosition): > (WebCore::RenderLayerCompositor::reportMemoryUsage): > * rendering/RenderLayerCompositor.h: > (RenderLayerCompositor): > > LayoutTests: > > Tests to ensure mainThreadScrollingReasons are correctly updated after a fixed element is dynamically inserted into the DOM tree. > > * compositing/layer-creation/fixed-position-in-view-dynamic-expected.txt: Added. > * compositing/layer-creation/fixed-position-in-view-dynamic.html: Added. > * compositing/layer-creation/fixed-position-out-of-view-dynamic-expected.txt: Added. > * compositing/layer-creation/fixed-position-out-of-view-dynamic.html: Added. > TBR=wangxianzhu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139984

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -44 lines) Patch
A + LayoutTests/compositing/layer-creation/fixed-position-in-view-dynamic.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/compositing/layer-creation/fixed-position-in-view-dynamic-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/compositing/layer-creation/fixed-position-out-of-view-dynamic.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/compositing/layer-creation/fixed-position-out-of-view-dynamic-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/page/scrolling/ScrollingCoordinator.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebCore/page/scrolling/ScrollingCoordinator.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/rendering/RenderLayer.h View 2 chunks +12 lines, -0 lines 0 comments Download
M Source/WebCore/rendering/RenderLayer.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/WebCore/rendering/RenderLayerCompositor.h View 4 chunks +3 lines, -14 lines 0 comments Download
M Source/WebCore/rendering/RenderLayerCompositor.cpp View 11 chunks +27 lines, -22 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Xianzhu
7 years, 11 months ago (2013-01-17 17:25:33 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698