Issue 11970011: Add an element for mixin applications. For now, the resolver complains about mixin applications -- …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11970011: Add an element for mixin applications. For now, the resolver complains about mixin applications -- … (Closed)

Created:
7 years, 11 months ago by kasperl

Modified:
7 years, 11 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add an element for mixin applications. For now, the resolver complains about mixin applications -- but at least now the listeners support them. R=ahe@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=17267

Patch Set 1 #

Total comments: 1

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -19 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/elements/elements.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/elements/modelx.dart	View	3 chunks	+23 lines, -12 lines	1 comment	Download
M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/scanner/listener.dart	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/scanner/scannerlib.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

Can you test this by doing something like tests/compiler/dart2js/metadata_test.dart? https://codereview.chromium.org/11970011/diff/1/sdk/lib/_internal/compiler/implementation/elements/modelx.dart File sdk/lib/_internal/compiler/implementation/elements/modelx.dart (right): https://codereview.chromium.org/11970011/diff/1/sdk/lib/_internal/compiler/implementation/elements/modelx.dart#newcode1764 sdk/lib/_internal/compiler/implementation/elements/modelx.dart:1764: ...

7 years, 11 months ago (2013-01-18 12:15:48 UTC) #2

kasperl

7 years, 11 months ago (2013-01-18 12:59:24 UTC) #4

Message was sent while issue was closed.

Thanks, Peter. I'll address the concerns in another CL. Stay tuned.

Expand Messages | Collapse Messages