Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart

Issue 11970007: Address Erik's comments on https://codereview.chromium.org/11778064 and fix minifier failures. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/lib/js_helper.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart (revision 17128)
+++ sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart (working copy)
@@ -385,10 +385,10 @@
const String _SPAWNED_SIGNAL = "spawned";
var globalThis = IsolateNatives.computeGlobalThis();
-var globalWindow = JS('', "#['window']", globalThis);
-var globalWorker = JS('', "#['Worker']", globalThis);
+var globalWindow = JS('', "#.window", globalThis);
+var globalWorker = JS('', "#.Worker", globalThis);
bool globalPostMessageDefined =
- JS('', "#['postMessage'] !== (void 0)", globalThis);
+ JS('', "#.postMessage !== (void 0)", globalThis);
class IsolateNatives {
@@ -406,9 +406,11 @@
// executed. The last one is the currently running script.
for (var script in scripts) {
var src = JS('String|Null', '# && #.src', script, script);
+ // Filter out the test controller script, and the Dart
+ // bootstrap script.
if (src != null
&& !src.endsWith('test_controller.js')
- && !new RegExp('client.dart\.js').hasMatch(src)) {
ngeoffray 2013/01/16 10:33:38 The path has now changed. To make things simple, I
+ && !src.endsWith('dart.js')) {
return src;
}
}
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/lib/js_helper.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698