Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1158)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sdk/lib/_internal/compiler/implementation/lib/js_helper.dart

Issue 11970007: Address Erik's comments on https://codereview.chromium.org/11778064 and fix minifier failures. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart ('K') | « sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/lib/js_helper.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/lib/js_helper.dart (revision 17128)
+++ sdk/lib/_internal/compiler/implementation/lib/js_helper.dart (working copy)
@@ -1125,8 +1125,10 @@
// executes.
var currentIsolate = JS_CURRENT_ISOLATE();
+ // We use $0 and $1 to not clash with variable names used by the
+ // compiler and/or minifier.
function = JS("var",
- r"""function(a, b) { return #(#, #, #, a, b); }""",
+ r"""function($0, $1) { return #(#, #, #, $0, $1); }""",
DART_CLOSURE_TO_JS(invokeClosure),
closure,
JS_CURRENT_ISOLATE(),
« sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart ('K') | « sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698