Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(949)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11968047: Fixing formatting of dart:html's dart2js annotations. (Closed)

Created:
7 years, 11 months ago by blois
Modified:
7 years, 11 months ago
Reviewers:
rakudrama, sra1
CC:
reviews_dartlang.org, Andrei Mouravski
Visibility:
Public.

Description

Fixing formatting of dart:html's dart2js annotations. Also unifying formatting of attributes. BUG=7808 Committed: https://code.google.com/p/dart/source/detail?r=17238

Patch Set 1 #

Total comments: 4

Patch Set 2 : CR feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6718 lines, -3410 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 354 chunks +4142 lines, -2042 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 13 chunks +25 lines, -21 lines 0 comments Download
M sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart View 30 chunks +224 lines, -109 lines 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 167 chunks +1884 lines, -942 lines 0 comments Download
M sdk/lib/web_audio/dart2js/web_audio_dart2js.dart View 22 chunks +218 lines, -109 lines 0 comments Download
M tools/dom/scripts/generator.py View 1 5 chunks +107 lines, -59 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 2 chunks +10 lines, -11 lines 0 comments Download
M tools/dom/scripts/systemnative.py View 1 chunk +5 lines, -8 lines 0 comments Download
M tools/dom/templates/dart2js_impl.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/dart2js/impl_ArrayBuffer.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/dart2js/impl_AudioBufferSourceNode.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/dart2js/impl_Console.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/dart2js/impl_ElementEvents.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/impl_HTMLTableElement.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/dart2js/impl_IDBDatabase.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/dart2js/impl_KeyboardEvent.darttemplate View 1 chunk +1 line, -2 lines 0 comments Download
M tools/dom/templates/html/dart2js/impl_MouseEvent.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/dart2js/impl_Navigator.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/dart2js/impl_URL.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/dart2js/impl_Window.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/dart2js/impl_WorkerContext.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/dartium/dart_implementation.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/dartium/impl_KeyboardEvent.darttemplate View 2 chunks +4 lines, -4 lines 0 comments Download
M tools/dom/templates/html/dartium/impl_MouseEvent.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/dartium/impl_Window.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_AudioContext.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Blob.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_CustomEvent.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Document.darttemplate View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_DocumentFragment.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_Event.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_EventTarget.darttemplate View 3 chunks +4 lines, -4 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLCanvasElement.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLInputElement.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLSelectElement.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_History.darttemplate View 1 chunk +1 line, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_IDBFactory.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_IDBKeyRange.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_MutationObserver.darttemplate View 1 chunk +2 lines, -6 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Node.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Range.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_SVGElement.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_SVGSVGElement.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_ShadowRoot.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Storage.darttemplate View 1 chunk +3 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Text.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_UIEvent.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_WheelEvent.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate View 3 chunks +12 lines, -13 lines 0 comments Download
M tools/dom/templates/html/impl/pure_interface.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 11 months ago (2013-01-17 19:24:42 UTC) #1
rakudrama
lgtm (sra) https://codereview.chromium.org/11968047/diff/1/tools/dom/scripts/generator.py File tools/dom/scripts/generator.py (right): https://codereview.chromium.org/11968047/diff/1/tools/dom/scripts/generator.py#newcode816 tools/dom/scripts/generator.py:816: def FormatAnnotations(annotations, indentation, trailing_newline=False): Trailing_newline unused https://codereview.chromium.org/11968047/diff/1/tools/dom/scripts/generator.py#newcode817 ...
7 years, 11 months ago (2013-01-17 21:19:24 UTC) #2
blois
7 years, 11 months ago (2013-01-17 22:12:06 UTC) #3 
Don't know who this rakudrama guy is, but I'll trust him when he says 'lgtm'.

https://codereview.chromium.org/11968047/diff/1/tools/dom/scripts/generator.py
File tools/dom/scripts/generator.py (right):

https://codereview.chromium.org/11968047/diff/1/tools/dom/scripts/generator.p...
tools/dom/scripts/generator.py:816: def FormatAnnotations(annotations,
indentation, trailing_newline=False):
On 2013/01/17 21:19:24, rakudrama wrote:
> Trailing_newline unused

Done.

https://codereview.chromium.org/11968047/diff/1/tools/dom/scripts/generator.p...
tools/dom/scripts/generator.py:817: if annotations and len(annotations) > 0:
On 2013/01/17 21:19:24, rakudrama wrote:
> Empty list is falsy so "if annotations:" should be sufficient

Done.

Powered by Google App Engine
This is Rietveld 408576698