Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1956)

Unified Diff: sdk/lib/_internal/compiler/implementation/elements/elements.dart

Issue 11967010: Internal libraries supported. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/elements/elements.dart
diff --git a/sdk/lib/_internal/compiler/implementation/elements/elements.dart b/sdk/lib/_internal/compiler/implementation/elements/elements.dart
index 7890981eb002f27662f6f271e4aa7982a620aff8..ede8347b789ae2da3d3bf16ebb8629f6c1a4fbe6 100644
--- a/sdk/lib/_internal/compiler/implementation/elements/elements.dart
+++ b/sdk/lib/_internal/compiler/implementation/elements/elements.dart
@@ -471,6 +471,13 @@ abstract class CompilationUnitElement extends Element {
}
abstract class LibraryElement extends Element implements ScopeContainerElement {
+ /**
+ * The canonical uri for this library.
+ *
+ * For user libraries the canonical uri is the script uri. For platform
+ * libraries the canonical uri is of the form [:dart:x:], and for a patch
+ * library for [:dart:x:] the canonical uri is [:patch:_x:].
ahe 2013/01/18 11:03:10 Why add an underscore?
Johnni Winther 2013/01/21 09:27:54 No need. The scheme is enough protection that we c
+ */
Uri get uri;
CompilationUnitElement get entryCompilationUnit;
Link<CompilationUnitElement> get compilationUnits;
@@ -478,7 +485,17 @@ abstract class LibraryElement extends Element implements ScopeContainerElement {
LibraryName get libraryTag;
Link<Element> get exports;
+ /**
+ * [:true:] if this library is part of the platform, i.e. its canonical
ahe 2013/01/18 11:03:10 i.e. -> that is (not all of us have studied ancien
Johnni Winther 2013/01/21 09:27:54 Well, I didn't write 'id est' ;-)
+ * uri has the scheme 'dart'.
+ */
bool get isPlatformLibrary;
+
+ /**
+ * [:true:] if this library is a platform library whose path starts with
ahe 2013/01/18 11:03:10 I'm concerned about this approach. It seems brittl
Johnni Winther 2013/01/21 09:27:54 The security is based on the [isPlatformLibrary] c
+ * an underscore.
+ */
+ bool get isPrivateLibrary;
bool get canUseNative;
bool get exportsHandled;

Powered by Google App Engine
This is Rietveld 408576698