sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart - Issue 11967010: Internal libraries supported.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart

Issue 11967010: Internal libraries supported. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/compiler.dart ('K') | « sdk/lib/_internal/compiler/implementation/compiler.dart ('k') | sdk/lib/_internal/compiler/implementation/elements/elements.dart » ('j') | sdk/lib/_internal/compiler/implementation/elements/elements.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart

diff --git a/sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart b/sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart

index 5c2a13e8739a067cc804a9c03c0c5a9772598809..2d4822f412805b9703e0c0d3aa21b9ae569532fc 100644

--- a/sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart

+++ b/sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart

@@ -142,7 +142,7 @@ void renamePlaceholders(

if (identical(element.getLibrary(), compiler.coreLibrary)) {

return originalName;

}

- if (library.isPlatformLibrary) {

+ if (library.isPlatformLibrary && !library.isPrivateLibrary) {

ngeoffray 2013/01/16 15:40:57 Should it be called InternalLibrary? Private alrea

ahe 2013/01/18 11:03:10 Excellent point.

Johnni Winther 2013/01/21 09:27:54 Good idea. Renamed the concept to 'internal librar

assert(element.isTopLevel());

final prefix =

imports.putIfAbsent(library, () => generateUniqueName('p'));