remove SkDeviceProperties

remove SkDeviceProperties

There is a lot more clean up to do here but this is probably a big enough bite.

Committed: https://skia.googlesource.com/skia/+/fcf7829b67b798aff4c41c4688daa9c7381991e6

[robertphillips, 2015-06-19 16:54:13]

robertphillips@google.com changed reviewers:
+ bungeman@chromium.org, bungeman@google.com, reed@google.com

[robertphillips, 2015-06-19 16:54:29]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-06-19 16:54:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1196683003/20001

[commit-bot: I haz the power, 2015-06-19 17:00:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-19 17:00:25]

Dry run: This issue passed the CQ dry run.

[bungeman-skia, 2015-06-19 17:35:34]

https://codereview.chromium.org/1196683003/diff/20001/src/gpu/SkGpuDevice.h
File src/gpu/SkGpuDevice.h (right):

https://codereview.chromium.org/1196683003/diff/20001/src/gpu/SkGpuDevice.h#n...
src/gpu/SkGpuDevice.h:80: return this->getLeakyProperties();
Does this make sense? The leaky properties are those properties which are set on
the device but the device doesn't know how to apply. The idea is that while the
device doesn't know how to apply these properties itself, other components can
sniff these and try to apply them as best they can.

In other words, when srgb support is added I would expect the leaky properties
to not be equal to the actual surface properties. Once there are no leaky
properties (all devices support linear or srgb properly and there's no text
gamma fiddling) then the leaky properties dance can go away.

[bungeman-skia, 2015-06-19 18:27:31]

lgtm so long as we follow up by removing/renaming any remaining leakyProp things
now that there are no leaky props. There will also need to be some changes cpu
side when it supports srgb blitting so that it can also ignoreGamma for the
glyph masks.

https://codereview.chromium.org/1196683003/diff/20001/src/gpu/SkGpuDevice.h
File src/gpu/SkGpuDevice.h (right):

https://codereview.chromium.org/1196683003/diff/20001/src/gpu/SkGpuDevice.h#n...
src/gpu/SkGpuDevice.h:80: return this->getLeakyProperties();
On 2015/06/19 17:35:34, bungeman1 wrote:
> Does this make sense? The leaky properties are those properties which are set
on
> the device but the device doesn't know how to apply. The idea is that while
the
> device doesn't know how to apply these properties itself, other components can
> sniff these and try to apply them as best they can.
> 
> In other words, when srgb support is added I would expect the leaky properties
> to not be equal to the actual surface properties. Once there are no leaky
> properties (all devices support linear or srgb properly and there's no text
> gamma fiddling) then the leaky properties dance can go away.

Ah, so no one is using the leaky properties.

[robertphillips, 2015-06-19 18:27:47]

https://codereview.chromium.org/1196683003/diff/20001/src/gpu/SkGpuDevice.h
File src/gpu/SkGpuDevice.h (right):

https://codereview.chromium.org/1196683003/diff/20001/src/gpu/SkGpuDevice.h#n...
src/gpu/SkGpuDevice.h:80: return this->getLeakyProperties();
As discussed in person I will follow up this CL with another one that will
rename all of SkDevice's "leaky"-props instances\names with "surface"-props
variants.

[bungeman-skia, 2015-06-19 18:33:18]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2015-06-19 18:33:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1196683003/20001

[commit-bot: I haz the power, 2015-06-19 18:35:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-19 18:35:02]

Try jobs failed on following builders:
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[reed1, 2015-06-19 18:47:34]

lgtm

AWESOME!

[bungeman-skia, 2015-06-19 18:48:31]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2015-06-19 18:48:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1196683003/20001

[commit-bot: I haz the power, 2015-06-19 18:49:56]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/fcf7829b67b798aff4c41c4688daa9c7381991e6