remove SkDeviceProperties

src/gpu/SkGpuDevice.h

Index: src/gpu/SkGpuDevice.h
diff --git a/src/gpu/SkGpuDevice.h b/src/gpu/SkGpuDevice.h
index cf85cd967398d2cb7fa25ef15944a9da1daf89c9..5b54fafb26eaddf0dadccc6e0e6b0803d08a951c 100644
--- a/src/gpu/SkGpuDevice.h
+++ b/src/gpu/SkGpuDevice.h
@@ -76,7 +76,9 @@ public:
         return fLegacyBitmap.info();
     }
 
-    const SkSurfaceProps& surfaceProps() const { return fSurfaceProps; }
+    const SkSurfaceProps& surfaceProps() const {
+        return this->getLeakyProperties();

[bungeman-skia, 2015/06/19 17:35:34]

Does this make sense? The leaky properties are those properties which are set on
the device but the device doesn't know how to apply. The idea is that while the
device doesn't know how to apply these properties itself, other components can
sniff these and try to apply them as best they can.

In other words, when srgb support is added I would expect the leaky properties
to not be equal to the actual surface properties. Once there are no leaky
properties (all devices support linear or srgb properly and there's no text
gamma fiddling) then the leaky properties dance can go away.

[bungeman-skia, 2015/06/19 18:27:30]

Ah, so no one is using the leaky properties.

[robertphillips, 2015/06/19 18:27:47]

As discussed in person I will follow up this CL with another one that will
rename all of SkDevice's "leaky"-props instances\names with "surface"-props
variants.

+    }
 
     void drawPaint(const SkDraw&, const SkPaint& paint) override;
     virtual void drawPoints(const SkDraw&, SkCanvas::PointMode mode, size_t count,
@@ -151,7 +153,6 @@ private:
     SkIPoint                        fClipOrigin;
     GrClip                          fClip;
     SkAutoTUnref<GrDrawContext>     fDrawContext;
-    SkSurfaceProps                  fSurfaceProps;
     GrRenderTarget*                 fRenderTarget;
     // remove when our clients don't rely on accessBitmap()
     SkBitmap                        fLegacyBitmap;