test/cctest/compiler/test-representation-change.cc - Issue 1196623002: [ubsan] Fix HeapObjectMatcher to avoid invalid casts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/compiler/test-representation-change.cc

Issue 1196623002: [ubsan] Fix HeapObjectMatcher to avoid invalid casts. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: REBASE Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/compiler/test-representation-change.cc

diff --git a/test/cctest/compiler/test-representation-change.cc b/test/cctest/compiler/test-representation-change.cc

index 7aa0e38e7e8321f1d108ca89a3d9be08cc26bac7..216f9fd847e3e54840038f42fb114e403cf70686 100644

--- a/test/cctest/compiler/test-representation-change.cc

+++ b/test/cctest/compiler/test-representation-change.cc

@@ -69,7 +69,7 @@ class RepresentationChangerTester : public HandleAndZoneScope,

}

void CheckHeapConstant(Node* n, HeapObject* expected) {

- HeapObjectMatcher<HeapObject> m(n);

+ HeapObjectMatcher m(n);

CHECK(m.HasValue());

CHECK_EQ(expected, *m.Value().handle());

}