Issue 1196463002: Don't crash if you call document.createText(null)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1196463002: Don't crash if you call document.createText(null) (Closed)

Created:
5 years, 6 months ago by abarth-chromium

Modified:
5 years, 6 months ago

Reviewers:
jackson_old, jackson

CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -9 lines)			Patch
M	sky/engine/core/dom/Document.idl	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	sky/tests/raw/null_text_crash.dart	View	1 chunk	+5 lines, -7 lines	0 comments	Download
A +	sky/tests/raw/null_text_crash-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

abarth-chromium

5 years, 6 months ago (2015-06-18 19:17:10 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0c35e6c19c7e45bf52bea266839c4bf29ef6ae1e (presubmit successful).