sky/engine/core/dom/Document.idl - Issue 1196463002: Don't crash if you call document.createText(null)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/dom/Document.idl

Issue 1196463002: Don't crash if you call document.createText(null) (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/dom/Document.idl

diff --git a/sky/engine/core/dom/Document.idl b/sky/engine/core/dom/Document.idl

index 50ee8bbd56895a7a37c78be851faeb9831f0ba97..d3058aa63da6e95cb97d29c1b4c318e0545db1f7 100644

--- a/sky/engine/core/dom/Document.idl

+++ b/sky/engine/core/dom/Document.idl

@@ -24,7 +24,7 @@ callback CustomElementConstructor = Element ();

Constructor(),

] interface Document : ParentNode {

[CustomElementCallbacks, RaisesException] Element createElement(DOMString tagName);

- Text createText(DOMString text);

+ Text createText(DOMString? text);

DocumentFragment createDocumentFragment();

« no previous file with comments | « no previous file | sky/tests/raw/null_text_crash.dart » ('j') | no next file with comments »