Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Issue 1196293002: HTMLPreloadScanner should also add width to non-`w` based image resources (Closed)

Created:
5 years, 6 months ago by Yoav Weiss
Modified:
5 years, 6 months ago
Reviewers:
Mike West
CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink, Yoav Weiss
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

HTMLPreloadScanner should also add width to non-`w` based image resources The HTMLPreloadScanner was not adding sizes based Width values to requests issued by <img> tags where only `src` was present or the picked `srcset` candidate was based on an `x` descriptor. This CL fixes that issue and adds tests to make sure it won't regress. BUG=458983 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197640

Patch Set 1 #

Patch Set 2 : Removed duplicate layout test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M Source/core/html/parser/HTMLPreloadScanner.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLPreloadScannerTest.cpp View 3 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Yoav Weiss
Hey Mike, Due to some faulty logic when adding preloadScanner support, I limited precise "Width:"/"RW" ...
5 years, 6 months ago (2015-06-22 14:33:07 UTC) #2
Mike West
lgtm
5 years, 6 months ago (2015-06-23 09:19:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1196293002/20001
5 years, 6 months ago (2015-06-23 09:19:34 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-23 10:26:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197640

Powered by Google App Engine
This is Rietveld 408576698