Source/core/html/parser/HTMLPreloadScanner.cpp - Issue 1196293002: HTMLPreloadScanner should also add width to non-`w` based image resources

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/parser/HTMLPreloadScanner.cpp

Issue 1196293002: HTMLPreloadScanner should also add width to non-`w` based image resources (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Removed duplicate layout test Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/parser/HTMLPreloadScanner.cpp

diff --git a/Source/core/html/parser/HTMLPreloadScanner.cpp b/Source/core/html/parser/HTMLPreloadScanner.cpp

index 2865b39e6bfe55f54efeefcf7f184fe538944549..9be5f68cdc0d1de07a09b82dea8dfba67030428b 100644

--- a/Source/core/html/parser/HTMLPreloadScanner.cpp

+++ b/Source/core/html/parser/HTMLPreloadScanner.cpp

@@ -182,7 +182,7 @@ public:

TextPosition position = TextPosition(source.currentLine(), source.currentColumn());

FetchRequest::ResourceWidth resourceWidth;

- if (m_sourceSizeSet && m_srcsetImageCandidate.resourceWidth() != UninitializedDescriptor) {

+ if (m_sourceSizeSet) {

resourceWidth.width = m_sourceSize;

resourceWidth.isSet = true;

} else {

« no previous file with comments | « no previous file | Source/core/html/parser/HTMLPreloadScannerTest.cpp » ('j') | no next file with comments »