Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1196283003: HTMLTableColElement span type set to unsigned (Closed)

Created:
5 years, 6 months ago by Habib Virji
Modified:
5 years, 6 months ago
Reviewers:
tkent, philipj_slow
CC:
blink-reviews, arv+blink, vivekg_samsung, blink-reviews-html_chromium.org, vivekg, dglazkov+blink, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

HTMLTableColElement span attribute type set to unsigned Span type returns unsigned value. Its usage was already an unsigned value in LayoutTableCols. BUG=496400 R=philipj@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197686

Patch Set 1 #

Patch Set 2 : Updated test to reflect the changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -13 lines) Patch
M LayoutTests/fast/dom/HTMLTableColElement/span-attribute.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/HTMLTableColElement/span-attribute-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTableColElement.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLTableColElement.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLTableColElement.idl View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1196283003/1
5 years, 6 months ago (2015-06-22 14:46:14 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1196283003/20001
5 years, 6 months ago (2015-06-22 15:45:57 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/60108)
5 years, 6 months ago (2015-06-22 16:57:02 UTC) #6
Habib Virji
PTAL. mac bot failure does not seem to be related to this CL.
5 years, 6 months ago (2015-06-23 10:55:48 UTC) #8
philipj_slow
Per spec <https://html.spec.whatwg.org/#dom-colgroup-span>, "The span IDL attribute must reflect the content attribute of the same ...
5 years, 6 months ago (2015-06-23 14:15:51 UTC) #9
Rick Byers
Replacing myself with tkent who is specifically interested in DOM API conformance.
5 years, 6 months ago (2015-06-23 21:11:12 UTC) #12
tkent
lgtm
5 years, 6 months ago (2015-06-23 23:31:05 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1196283003/20001
5 years, 6 months ago (2015-06-23 23:31:47 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=197686
5 years, 6 months ago (2015-06-24 00:38:42 UTC) #17
Habib Virji
@philipj: I have not checked viability of the above suggestion. Since this CL has landed ...
5 years, 6 months ago (2015-06-25 13:27:34 UTC) #18
philipj_slow
5 years, 6 months ago (2015-06-26 13:08:04 UTC) #19
Message was sent while issue was closed. 
On 2015/06/25 13:27:34, Habib Virji wrote:
> @philipj: I have not checked viability of the above suggestion. Since this CL
> has landed should I look into it ?

No, you can leave it alone, it would just be cleanup that isn't web-observable,
and might not actually be cleaner if there's some detail not apparent right now.

Powered by Google App Engine
This is Rietveld 408576698