Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Unified Diff: Source/core/html/HTMLTableColElement.cpp

Issue 1196283003: HTMLTableColElement span type set to unsigned (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Updated test to reflect the changes Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLTableColElement.h ('k') | Source/core/html/HTMLTableColElement.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLTableColElement.cpp
diff --git a/Source/core/html/HTMLTableColElement.cpp b/Source/core/html/HTMLTableColElement.cpp
index 878d3657f8b459d2f39f2d47ee8d130929e1387b..fa06ce204c0dda31d80e4a919124e104f2e6cdb7 100644
--- a/Source/core/html/HTMLTableColElement.cpp
+++ b/Source/core/html/HTMLTableColElement.cpp
@@ -61,8 +61,8 @@ void HTMLTableColElement::collectStyleForPresentationAttribute(const QualifiedNa
void HTMLTableColElement::parseAttribute(const QualifiedName& name, const AtomicString& value)
{
if (name == spanAttr) {
- int newSpan = 0;
- if (value.isEmpty() || !parseHTMLInteger(value, newSpan) || newSpan < 1) {
+ unsigned newSpan = 0;
+ if (value.isEmpty() || !parseHTMLNonNegativeInteger(value, newSpan) || newSpan < 1) {
// If the value of span is not a valid non-negative integer greater than zero,
// set it to 1.
newSpan = 1;
@@ -92,9 +92,9 @@ const StylePropertySet* HTMLTableColElement::additionalPresentationAttributeStyl
return nullptr;
}
-void HTMLTableColElement::setSpan(int n)
+void HTMLTableColElement::setSpan(unsigned n)
{
- setIntegralAttribute(spanAttr, n);
+ setUnsignedIntegralAttribute(spanAttr, n);
}
const AtomicString& HTMLTableColElement::width() const
« no previous file with comments | « Source/core/html/HTMLTableColElement.h ('k') | Source/core/html/HTMLTableColElement.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698