Remove duplicate measure hyphen string method

Remove duplicate measure hyphen string method

Remove duplicate measure hyphen string method. We are having two methods
to calculate Hyphen string width. One in LayoutText and another in
BreakingContextInlineHeaders. This patch removed duplicated method
from BreakingContextInlineHeaders.

TEST=none

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197692

[h.joshi, 2015-06-22 07:07:49]

h.joshi@samsung.com changed reviewers:
- rob.buis@samsung.com

[h.joshi, 2015-06-22 07:07:49]

Pls review.

[h.joshi, 2015-06-22 17:16:12]

h.joshi@samsung.com changed reviewers:
+ rob.buis@samsung.com

[rwlbuis, 2015-06-22 17:23:12]

https://codereview.chromium.org/1196213002/diff/1/Source/core/layout/LayoutTe...
File Source/core/layout/LayoutText.h (right):

https://codereview.chromium.org/1196213002/diff/1/Source/core/layout/LayoutTe...
Source/core/layout/LayoutText.h:144: static float hyphenWidth(LayoutText*, const
Font&, TextDirection);
The duplication is a nice find. But I am quite sure the inline should not be
lost, maybe that is why it is duplicated. Do you think you can make it inline
and not duplicated?

[h.joshi, 2015-06-23 04:30:12]

Made changes, pls review.

https://codereview.chromium.org/1196213002/diff/1/Source/core/layout/LayoutTe...
File Source/core/layout/LayoutText.h (right):

https://codereview.chromium.org/1196213002/diff/1/Source/core/layout/LayoutTe...
Source/core/layout/LayoutText.h:144: static float hyphenWidth(LayoutText*, const
Font&, TextDirection);
On 2015/06/22 17:23:12, rwlbuis wrote:
> The duplication is a nice find. But I am quite sure the inline should not be
> lost, maybe that is why it is duplicated. Do you think you can make it inline
> and not duplicated?

Done, made method inline and removed static natue. Static nature does not seems
to be adding much once method is inlined.

[rwlbuis, 2015-06-23 15:50:09]

On 2015/06/23 04:30:12, h.joshi wrote:
> Made changes, pls review.
> 
>
https://codereview.chromium.org/1196213002/diff/1/Source/core/layout/LayoutTe...
> File Source/core/layout/LayoutText.h (right):
> 
>
https://codereview.chromium.org/1196213002/diff/1/Source/core/layout/LayoutTe...
> Source/core/layout/LayoutText.h:144: static float hyphenWidth(LayoutText*,
const
> Font&, TextDirection);
> On 2015/06/22 17:23:12, rwlbuis wrote:
> > The duplication is a nice find. But I am quite sure the inline should not be
> > lost, maybe that is why it is duplicated. Do you think you can make it
inline
> > and not duplicated?
> 
> Done, made method inline and removed static natue. Static nature does not
seems
> to be adding much once method is inlined.

Static will at least indicate the method does not use the class members, but I
think this is fine. I'll try to find a reviewer.

Btw AFAIK TEST=none is not needed, you can probably either say why a test is not
possible or not say anything at all.

[rwlbuis, 2015-06-23 15:51:12]

rob.buis@samsung.com changed reviewers:
+ eae@chromium.org

[rwlbuis, 2015-06-23 15:51:12]

PTAL

[eae, 2015-06-23 16:44:30]

LGTM

[h.joshi, 2015-06-23 23:07:15]

Thank you Emil.

[h.joshi, 2015-06-23 23:07:23]

The CQ bit was checked by h.joshi@samsung.com

[commit-bot: I haz the power, 2015-06-23 23:08:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1196213002/20001

[commit-bot: I haz the power, 2015-06-24 01:13:32]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197692