Source/core/layout/LayoutBlockFlowLine.cpp - Issue 1196213002: Remove duplicate measure hyphen string method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutBlockFlowLine.cpp

Issue 1196213002: Remove duplicate measure hyphen string method (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Making hyphenWidth as inline and removing static nature Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/layout/LayoutBlockFlowLine.cpp

diff --git a/Source/core/layout/LayoutBlockFlowLine.cpp b/Source/core/layout/LayoutBlockFlowLine.cpp

index d2f019afb8326c13d52344df1aeed22f5ecdb944..e6480a0aa76ce05059c525d11a0db0381dce48eb 100644

--- a/Source/core/layout/LayoutBlockFlowLine.cpp

+++ b/Source/core/layout/LayoutBlockFlowLine.cpp

@@ -379,7 +379,7 @@ static inline void setLogicalWidthForTextRun(RootInlineBox* lineBox, BidiRun* ru

LayoutUnit hyphenWidth = 0;

if (toInlineTextBox(run->m_box)->hasHyphen())

- hyphenWidth = measureHyphenWidth(layoutText, font, run->direction());

+ hyphenWidth = layoutText->hyphenWidth(font, run->direction());

float measuredWidth = 0;

FloatRect glyphBounds;

« no previous file with comments | « no previous file | Source/core/layout/LayoutText.h » ('j') | no next file with comments »