|
Revert 177182 - ViewTest.ChangeNativeViewHierarchyFindRoots failure
> Finally rip the global StackingClient bandaid off.
>
> - Removes the aura::client::SetStackingClient(StackingClient*) interface.
> - Moves the ash StackingController from a singleton owned by ash::Shell to one StackingController per RootWindow owned by the ash::RootWindowController. (Also removes a spurious delegate method, where every implementation creates the same object, including tests.)
> - Removes the global DesktopStackingClient and related interfaces.
> - Fix the ChromeViewsDelegate so that it still sets context in chromeos builds.
> - Rename content::ShellStackingClientAsh to content::MinimalAsh to reflect what it really does.
>
> In addition, the following fix ups apply:
>
> - Previously, WebContentsViewAura asserted that it needed a context window. Now if no context window is provided, it isn't added to an aura hierarchy. There are times when that context doesn't exist: various chromeos dialogs that directly invoke WebView and toplevel extension/app windows that are created from background pages that don't have contexts.
>
> BUG= 161882
>
> Review URL: https://codereview.chromium.org/11829040
TBR=erg@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177190
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+146 lines, -231 lines) |
Patch |
 |
M |
ash/root_window_controller.h
|
View
|
|
2 chunks |
+0 lines, -3 lines |
0 comments
|
Download
|
 |
M |
ash/root_window_controller.cc
|
View
|
|
2 chunks |
+0 lines, -4 lines |
0 comments
|
Download
|
 |
M |
ash/shell.h
|
View
|
|
3 chunks |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
ash/shell.cc
|
View
|
|
4 chunks |
+9 lines, -0 lines |
0 comments
|
Download
|
 |
M |
ash/shell/shell_delegate_impl.h
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
ash/shell/shell_delegate_impl.cc
|
View
|
|
2 chunks |
+5 lines, -0 lines |
0 comments
|
Download
|
 |
M |
ash/shell_delegate.h
|
View
|
|
2 chunks |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
ash/test/test_shell_delegate.h
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
ash/test/test_shell_delegate.cc
|
View
|
|
2 chunks |
+5 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/app_modal_dialogs/javascript_app_modal_dialog.cc
|
View
|
|
2 chunks |
+0 lines, -11 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/ash/chrome_shell_delegate.h
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/ash/chrome_shell_delegate.cc
|
View
|
|
2 chunks |
+5 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.h
|
View
|
|
2 chunks |
+7 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.cc
|
View
|
|
3 chunks |
+5 lines, -0 lines |
0 comments
|
Download
|
 |
A + |
chrome/browser/ui/aura/stacking_client_aura.h
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
A + |
chrome/browser/ui/aura/stacking_client_aura.cc
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/chrome_views_delegate.cc
|
View
|
|
2 chunks |
+2 lines, -10 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/chrome_web_dialog_view.cc
|
View
|
|
1 chunk |
+3 lines, -15 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/javascript_app_modal_dialog_views.cc
|
View
|
|
1 chunk |
+1 line, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/simple_message_box_views.cc
|
View
|
|
1 chunk |
+1 line, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/chrome_browser_ui.gypi
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
MM |
content/browser/web_contents/web_contents_view_aura.cc
|
View
|
|
1 chunk |
+4 lines, -12 lines |
0 comments
|
Download
|
 |
M |
content/content_shell.gypi
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
D |
content/shell/minimal_ash.h
|
View
|
|
1 chunk |
+0 lines, -66 lines |
0 comments
|
Download
|
 |
D |
content/shell/minimal_ash.cc
|
View
|
|
1 chunk |
+0 lines, -53 lines |
0 comments
|
Download
|
 |
M |
content/shell/shell.h
|
View
|
|
3 chunks |
+7 lines, -8 lines |
0 comments
|
Download
|
 |
M |
content/shell/shell_aura.cc
|
View
|
|
4 chunks |
+9 lines, -18 lines |
0 comments
|
Download
|
 |
A + |
content/shell/shell_stacking_client_ash.h
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
A + |
content/shell/shell_stacking_client_ash.cc
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
M |
ui/aura/client/stacking_client.h
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
ui/aura/client/stacking_client.cc
|
View
|
|
1 chunk |
+24 lines, -12 lines |
0 comments
|
Download
|
 |
M |
ui/aura/demo/demo_main.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
ui/aura/env.h
|
View
|
|
3 chunks |
+7 lines, -0 lines |
0 comments
|
Download
|
 |
M |
ui/aura/env.cc
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
ui/aura/test/test_stacking_client.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
ui/aura/window.cc
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
ui/views/examples/content_client/examples_browser_main_parts.h
|
View
|
|
2 chunks |
+9 lines, -0 lines |
0 comments
|
Download
|
 |
M |
ui/views/examples/content_client/examples_browser_main_parts.cc
|
View
|
|
3 chunks |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
ui/views/views.gyp
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
A + |
ui/views/widget/desktop_aura/desktop_stacking_client.h
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
A + |
ui/views/widget/desktop_aura/desktop_stacking_client.cc
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
M |
ui/views/widget/native_widget_aura.cc
|
View
|
|
1 chunk |
+9 lines, -2 lines |
0 comments
|
Download
|
 |
M |
ui/views/widget/widget.cc
|
View
|
|
2 chunks |
+6 lines, -7 lines |
0 comments
|
Download
|
Total messages: 1 (0 generated)
|