Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4180)

Unified Diff: chrome/browser/ui/views/chrome_web_dialog_view.cc

Issue 11962021: Revert 177182 - ViewTest.ChangeNativeViewHierarchyFindRoots failure (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/chrome_web_dialog_view.cc
===================================================================
--- chrome/browser/ui/views/chrome_web_dialog_view.cc (revision 177189)
+++ chrome/browser/ui/views/chrome_web_dialog_view.cc (working copy)
@@ -13,21 +13,9 @@
gfx::NativeWindow ShowWebDialog(gfx::NativeWindow parent,
content::BrowserContext* context,
ui::WebDialogDelegate* delegate) {
- views::Widget* widget = NULL;
- if (parent) {
- widget = views::Widget::CreateWindowWithParent(
- new views::WebDialogView(context,
- delegate,
- new ChromeWebContentsHandler),
- parent);
- } else {
- // We shouldn't be called with a NULL parent, but sometimes are.
- widget = views::Widget::CreateWindow(
- new views::WebDialogView(context,
- delegate,
- new ChromeWebContentsHandler));
- }
-
+ views::Widget* widget = views::Widget::CreateWindowWithParent(
+ new views::WebDialogView(context, delegate, new ChromeWebContentsHandler),
+ parent);
widget->Show();
return widget->GetNativeWindow();
}
« no previous file with comments | « chrome/browser/ui/views/chrome_views_delegate.cc ('k') | chrome/browser/ui/views/javascript_app_modal_dialog_views.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698