Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1120)

Unified Diff: net/quic/quic_time_test.cc

Issue 11961022: Remove default constructors for QuicTime and QuicTime::Delta and used static Zero() methods instead… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/quic_time_test.cc
diff --git a/net/quic/quic_time_test.cc b/net/quic/quic_time_test.cc
index 978bc43c7159ff6adab60cf48ecbf21fd2227776..53532893cfc2998ad7597b6fc3f029df770f109e 100644
--- a/net/quic/quic_time_test.cc
+++ b/net/quic/quic_time_test.cc
@@ -14,13 +14,14 @@ class QuicTimeDeltaTest : public ::testing::Test {
};
TEST_F(QuicTimeDeltaTest, Zero) {
- EXPECT_TRUE(QuicTime::Delta().IsZero());
+ EXPECT_TRUE(QuicTime::Delta::Zero().IsZero());
+ EXPECT_FALSE(QuicTime::Delta::Zero().IsInfinite());
EXPECT_FALSE(QuicTime::Delta::FromMilliseconds(1).IsZero());
}
TEST_F(QuicTimeDeltaTest, Infinite) {
EXPECT_TRUE(QuicTime::Delta::Infinite().IsInfinite());
- EXPECT_FALSE(QuicTime::Delta().IsInfinite());
+ EXPECT_FALSE(QuicTime::Delta::Zero().IsInfinite());
EXPECT_FALSE(QuicTime::Delta::FromMilliseconds(1).IsInfinite());
}
@@ -34,7 +35,7 @@ TEST_F(QuicTimeDeltaTest, FromTo) {
TEST_F(QuicTimeDeltaTest, Add) {
EXPECT_EQ(QuicTime::Delta::FromMicroseconds(2000),
- QuicTime::Delta().Add(QuicTime::Delta::FromMilliseconds(2)));
+ QuicTime::Delta::Zero().Add(QuicTime::Delta::FromMilliseconds(2)));
}
TEST_F(QuicTimeDeltaTest, Subtract) {
@@ -49,7 +50,7 @@ class QuicTimeTest : public ::testing::Test {
};
TEST_F(QuicTimeTest, Initialized) {
- EXPECT_FALSE(QuicTime().IsInitialized());
+ EXPECT_FALSE(QuicTime::Zero().IsInitialized());
EXPECT_TRUE(QuicTime::FromMilliseconds(1).IsInitialized());
}

Powered by Google App Engine
This is Rietveld 408576698