Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: net/net.gyp

Issue 11959029: Make the v8 Isolate used in the proxy resolver explicit. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed component build Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/net.gyp
diff --git a/net/net.gyp b/net/net.gyp
index f15dbcde625a8ea939d0c0776a4f26e15b792d5c..ce2f18de6f36faaaaf0dbb45409455be3241cf49 100644
--- a/net/net.gyp
+++ b/net/net.gyp
@@ -1674,6 +1674,7 @@
[ 'use_v8_in_net==1', {
'dependencies': [
'net_with_v8',
+ '../v8/tools/gyp/v8.gyp:v8',
eroman 2013/01/18 19:21:14 why is this necessary? doesn't it already pick thi
Sven Panne 2013/01/21 08:50:06 Without this, 2 builder failed, see the try jobs f
],
}, { # else: !use_v8_in_net
'sources!': [
@@ -1815,6 +1816,7 @@
[ 'use_v8_in_net==1', {
'dependencies': [
'net_with_v8',
+ '../v8/tools/gyp/v8.gyp:v8',
eroman 2013/01/18 19:21:14 See question above.
Sven Panne 2013/01/21 08:50:06 See comment above. :)
],
}, { # else: !use_v8_in_net
'sources!': [

Powered by Google App Engine
This is Rietveld 408576698