Make the v8 Isolate used in the proxy resolver explicit.

net/net.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'chromium_code': 1,
 
     'linux_link_kerberos%': 0,
     'conditions': [
@@ skipping 1656 matching lines @@
         [ 'enable_built_in_dns!=1', {
             'sources!': [
               'dns/address_sorter_posix_unittest.cc',
               'dns/address_sorter_unittest.cc',
             ],
           },
         ],
         [ 'use_v8_in_net==1', {
             'dependencies': [
               'net_with_v8',
+              '../v8/tools/gyp/v8.gyp:v8',

[eroman, 2013/01/18 19:21:14]

why is this necessary? doesn't it already pick this up transitively from the
'net_with_v8' dependency?

[Sven Panne, 2013/01/21 08:50:06]

Without this, 2 builder failed, see the try jobs for patch set 7:

http://build.chromium.org/p/tryserver.chromium/builders/linux_chromeos/builds...
http://build.chromium.org/p/tryserver.chromium/builders/linux_clang/builds/77...

I don't have a GYP black belt, so I relied on Jochen who proposed these changes.
If there is a nicer way to achieve this, I'd be happy to learn it.

             ],
           }, {  # else: !use_v8_in_net
             'sources!': [
               'proxy/proxy_resolver_v8_unittest.cc',
             ],
           },
         ],
         [ 'OS == "win"', {
             'sources!': [
               'dns/dns_config_service_posix_unittest.cc',
@@ skipping 121 matching lines @@
       ],
       'sources': [
         'cookies/cookie_monster_perftest.cc',
         'disk_cache/disk_cache_perftest.cc',
         'proxy/proxy_resolver_perftest.cc',
       ],
       'conditions': [
         [ 'use_v8_in_net==1', {
             'dependencies': [
               'net_with_v8',
+              '../v8/tools/gyp/v8.gyp:v8',

[eroman, 2013/01/18 19:21:14]

See question above.

[Sven Panne, 2013/01/21 08:50:06]

See comment above. :)

             ],
           }, {  # else: !use_v8_in_net
             'sources!': [
               'proxy/proxy_resolver_perftest.cc',
             ],
           },
         ],
         # This is needed to trigger the dll copy step on windows.
         # TODO(mark): Specifying this here shouldn't be necessary.
         [ 'OS == "win"', {
@@ skipping 607 matching lines @@
                 '--result', '<@(_outputs)',
                 '--isolate', 'net_unittests.isolate',
               ],
             },
           ],
         },
       ],
     }],
   ],
 }