Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(785)

Issue 1145343005: Run mojo unit tests on the Android main waterfall. (Closed)

Created:
5 years, 6 months ago by msw
Modified:
5 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Run mojo unit tests on the Android main waterfall. Run Mojo additional unit tests on the "Android GN" bot: http://build.chromium.org/p/chromium.linux/builders/Android%20GN (No CQ yet; need Android GN testing support/devices there...) Add the necessary target mappings to ninja_to_gn.pyl Similar tests already run on Linux GN and our chromium.mojo FYI: http://build.chromium.org/p/chromium.linux/builders/Linux%20GN http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Android BUG=478244, 359249 TEST=Steps run and pass on the bot. R=dpranke@chromium.org Committed: https://crrev.com/e1d8b35e1745d299ef346b1b6b6d116f417d2664 Cr-Commit-Position: refs/heads/master@{#335112}

Patch Set 1 #

Patch Set 2 : Run other mojo unit tests on Android GN; Add ninja_to_gn.pyl entries. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -0 lines) Patch
M testing/buildbot/chromium.linux.json View 1 1 chunk +39 lines, -0 lines 0 comments Download
M testing/buildbot/ninja_to_gn.pyl View 1 4 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (1 generated)
msw
Hey Dirk, let me know when we are ready to try this out.
5 years, 6 months ago (2015-05-29 23:07:59 UTC) #1
Dirk Pranke
On 2015/05/29 23:07:59, msw wrote: > Hey Dirk, let me know when we are ready ...
5 years, 6 months ago (2015-05-29 23:09:30 UTC) #2
msw
Hey Dirk, I saw that you landed https://codereview.chromium.org/1153933004/ getting some GN bots ready to run ...
5 years, 6 months ago (2015-06-05 17:58:58 UTC) #3
Dirk Pranke
On 2015/06/05 17:58:58, msw wrote: > Hey Dirk, I saw that you landed https://codereview.chromium.org/1153933004/ > ...
5 years, 6 months ago (2015-06-05 18:01:09 UTC) #4
msw
On 2015/06/05 18:01:09, Dirk Pranke wrote: > On 2015/06/05 17:58:58, msw wrote: > > Hey ...
5 years, 6 months ago (2015-06-05 18:05:22 UTC) #5
msw
Hey Dirk, please take a fresh look; thanks!
5 years, 6 months ago (2015-06-18 18:30:52 UTC) #6
Dirk Pranke
lgtm
5 years, 6 months ago (2015-06-18 19:24:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145343005/20001
5 years, 6 months ago (2015-06-18 19:31:32 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-18 20:39:39 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/e1d8b35e1745d299ef346b1b6b6d116f417d2664 Cr-Commit-Position: refs/heads/master@{#335112}
5 years, 6 months ago (2015-06-18 20:40:30 UTC) #11
msw
5 years, 6 months ago (2015-06-18 20:55:08 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1177923004/ by msw@chromium.org.

The reason for reverting is:
http://build.chromium.org/p/chromium.linux/builders/Android%20GN/builds/26585...

ninja:error: unknown target 'html_viewer_unittests_apk'

.

Powered by Google App Engine
This is Rietveld 408576698